Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/firefox.js

Issue 29864558: Issue 6882 - always shutdown the browser gracefully (Closed)
Patch Set: Created Aug. 25, 2018, 9:27 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/firefox.js
diff --git a/test/firefox.js b/test/firefox.js
index 75d744358703ee3106fadcc91b3e0a8bdfb67209..9cd0a025122764d5d129dcca60d6f7553ee1929e 100644
--- a/test/firefox.js
+++ b/test/firefox.js
@@ -94,15 +94,9 @@ exports.runFirefox = function(test)
).then(() => Promise.all([
reportElements(test, driver, true),
reportElements(test, driver, false)
- ])).then(() =>
- {
- driver.quit();
- test.done();
- }, err =>
- driver.quit().then(() =>
- {
- throw err;
- })
+ ])).then(
+ () => driver.quit().then(() => test.done()),
+ err => driver.quit().then(() => { throw err; })
tlucas 2018/08/25 09:36:01 Our coding-style (https://adblockplus.org/en/codin
Sebastian Noack 2018/08/25 09:51:38 One liners are fine too.
);
});
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld