Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/exceptions/xmlhttprequest.tmpl

Issue 29871625: Noissue - Fixed "$xmlhttprequest Exception" test case (Closed)
Patch Set: Created Sept. 1, 2018, 7:25 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 title = $xmlhttprequest Exception 1 title = $xmlhttprequest Exception
2 template = testcase 2 template = testcase
3 3
4 {% set testcase_moreinfo = [ 4 {% set testcase_moreinfo = [
5 ("Filter Options", "https://adblockplus.org/filters#options"), 5 ("Filter Options", "https://adblockplus.org/filters#options"),
6 ] %} 6 ] %}
7 7
8 <script> 8 <script>
9 function aborted(evt) { 9 function aborted(evt) {
10 pagelog("XMLHTTPRequest was aborted."); 10 pagelog("XMLHTTPRequest was aborted.");
11 } 11 }
12 12
13 function failed(evt) { 13 function failed(evt) {
14 pagelog("XMLHTTPRequest failed."); 14 pagelog("XMLHTTPRequest failed.");
15 } 15 }
16 16
17 function makerequest() { 17 function makerequest() {
18 var req = new XMLHttpRequest(); 18 var req = new XMLHttpRequest();
19 req.addEventListener("error", failed); 19 req.addEventListener("error", failed);
20 req.addEventListener("abort", aborted); 20 req.addEventListener("abort", aborted);
21 req.open("GET", "http://testpages.adblockplus.org/testcasefiles/xmlhttprequest exception/text.txt", true); 21 req.open("GET", "https://testpages.adblockplus.org/testcasefiles/xmlhttpreques texception/text.txt", true);
22 req.onload = function(e) { 22 req.onload = function(e) {
23 if (this.status == 200) { 23 if (this.status == 200) {
24 pagelog(this.responseText); 24 pagelog(this.responseText);
25 } 25 }
26 }; 26 };
27 req.send(); 27 req.send();
28 } 28 }
29 29
30 document.addEventListener('DOMContentLoaded', makerequest, false); 30 document.addEventListener('DOMContentLoaded', makerequest, false);
31 </script> 31 </script>
32 32
33 <section class="site-panel"> 33 <section class="site-panel">
34 <h2>$xmlhttprequest Exception</h2> 34 <h2>$xmlhttprequest Exception</h2>
35 <p>Check that usage of the $xmlhttprequest filter option in an exception filte r works as expected.</p> 35 <p>Check that usage of the $xmlhttprequest filter option in an exception filte r works as expected.</p>
36 <p>With the filter(s) displayed below each test case added to ABP (or with the testcase subscription installed and active), the XMLHTTPRequest should not be b locked while the image should be.</p> 36 <p>With the filter(s) displayed below each test case added to ABP (or with the testcase subscription installed and active), the XMLHTTPRequest should not be b locked while the image should be.</p>
37 </section> 37 </section>
38 38
39 <section class="site-panel"> 39 <section class="site-panel">
40 <h2>Test case</h2> 40 <h2>Test case</h2>
41 <p>The XMLHTTPRequest should not be blocked. The Image should be blocked.</p> 41 <p>The XMLHTTPRequest should not be blocked. The Image should be blocked.</p>
42 <div class="testcase-container"> 42 <div class="testcase-container">
43 <div class="testcase-row"> 43 <div class="testcase-row">
44 <h3>XMLHTTPRequest</h3><div id="testcase-output"></div> 44 <h3>XMLHTTPRequest</h3>
45 <div id="testcase-output"></div>
46 <div id="testcase-output-expected">
47 Text loaded via XMLHTTPRequest
48 </div>
45 </div> 49 </div>
46 <div class="testcase-row"> 50 <div class="testcase-row">
47 <h3>Image</h3><img class="testcase-image" src="/testcasefiles/xmlhttpreque stexception/image.jpg"/> 51 <h3>Image</h3><img class="blocked" src="/testcasefiles/xmlhttprequestexcep tion/image.jpg"/>
48 </div> 52 </div>
49 </div> 53 </div>
50 <h3>Filters</h3> 54 <h3>Filters</h3>
51 <pre>||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*</pre> 55 <pre>||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*</pre>
Sebastian Noack 2018/09/01 19:30:48 There were several issues with this test case: 1.
52 <pre>@@testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/$xmlhtt prequest</pre> 56 <pre>@@testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/$xmlhtt prequest</pre>
53 </section> 57 </section>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld