Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/wrappers/pages.js

Issue 29871628: Issue 6918 - Integrated the test pages with the WebDriver-based test runner (Closed)
Left Patch Set: Created Sept. 2, 2018, 1:48 a.m.
Right Patch Set: Sort dependencies in package.json alphabetically Created Sept. 4, 2018, 2:29 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « test/.eslintrc.json ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 ]) 102 ])
103 )) 103 ))
104 ).then(testCases => 104 ).then(testCases =>
105 { 105 {
106 let p2 = Promise.resolve(); 106 let p2 = Promise.resolve();
107 for (let i = 0; i < testCases.length; i++) 107 for (let i = 0; i < testCases.length; i++)
108 { 108 {
109 let [title, expectedScreenshot, filters] = testCases[i]; 109 let [title, expectedScreenshot, filters] = testCases[i];
110 let platform = this.test.parent.title; 110 let platform = this.test.parent.title;
111 111
112 if (// https://codereview.adblockplus.org/29871606/ 112 if (// https://issues.adblockplus.org/ticket/6917
113 title == "Element Hiding Emulation / Extended Selectors - " +
114 "Case insensative extended selectors" ||
115 // https://codereview.adblockplus.org/29871622/
116 title == "Element Hiding Emulation / Extended Selectors - " +
117 "Regular expression in :-abp-contains()" ||
118 // https://issues.adblockplus.org/ticket/6917
119 title == "$subdocument - Test case" && platform == "gecko" || 113 title == "$subdocument - Test case" && platform == "gecko" ||
120 // https://codereview.adblockplus.org/29871625/
121 title == "$xmlhttprequest Exception - Test case" ||
122 // Chromium doesn't support Flash 114 // Chromium doesn't support Flash
123 /^\$object(-subrequest)?\b/.test(title) && platform == "chrome") 115 /^\$object(-subrequest)? /.test(title) && platform == "chrome")
124 continue; 116 continue;
125 117
126 p2 = p2.then(() => 118 p2 = p2.then(() =>
127 this.driver.navigate().to(this.origin + "/options.html") 119 this.driver.navigate().to(this.origin + "/options.html")
128 ).then(() => 120 ).then(() =>
129 this.driver.executeAsyncScript(` 121 this.driver.executeAsyncScript(`
130 let filters = arguments[0]; 122 let filters = arguments[0];
131 let callback = arguments[arguments.length - 1]; 123 let callback = arguments[arguments.length - 1];
132 browser.runtime.sendMessage({type: "subscriptions.get", 124 browser.runtime.sendMessage({type: "subscriptions.get",
133 downloadable: true, 125 downloadable: true,
(...skipping 22 matching lines...) Expand all
156 screenshot.data.compare(expectedScreenshot.data) == 0, 148 screenshot.data.compare(expectedScreenshot.data) == 0,
157 title 149 title
158 ) 150 )
159 ); 151 );
160 } 152 }
161 return p2; 153 return p2;
162 }); 154 });
163 return p1; 155 return p1;
164 }); 156 });
165 }); 157 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld