Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/exceptions/popup.tmpl

Issue 29874607: Issue 6769 - Avoid hardcoding the URL (Closed)
Patch Set: Rebased Created Sept. 24, 2018, 1:37 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pages/exceptions/image.tmpl ('k') | pages/exceptions/script.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 title = $popup Exception 1 title = $popup Exception
2 template = testcase 2 template = testcase
3 3
4 {% set testcase_moreinfo = [ 4 {% set testcase_moreinfo = [
5 ("Filter Options", "https://adblockplus.org/filters#options"), 5 ("Filter Options", "https://adblockplus.org/filters#options"),
6 ] %} 6 ] %}
7 7
8 <script> 8 <script>
9 function do_popup() 9 function do_popup()
10 { 10 {
11 window.open("/en/exceptions/popup") 11 window.open("/en/exceptions/popup")
12 } 12 }
13 </script> 13 </script>
14 14
15 <section class="site-panel"> 15 <section class="site-panel">
16 <h2>$popup Exception</h2> 16 <h2>$popup Exception</h2>
17 <p>Check that usage of the $popup filter option in an exception filter works a s expected.</p> 17 <p>Check that usage of the $popup filter option in an exception filter works a s expected.</p>
18 <p>With the filter(s) displayed below each test case added to ABP (or with the testcase subscription installed and active), the popup should not be blocked an d open succesfully.</p> 18 <p>With the filter(s) displayed below each test case added to ABP (or with the testcase subscription installed and active), the popup should not be blocked an d open succesfully.</p>
19 </section> 19 </section>
20 20
21 <section class="site-panel"> 21 <section class="site-panel">
22 <h2>Link-based popup</h2> 22 <h2>Link-based popup</h2>
23 <div class="testcase-container"> 23 <div class="testcase-container">
24 <a href="/en/exceptions/popup" target="_blank">Link popup</a><br><br> 24 <a href="/en/exceptions/popup" target="_blank">Link popup</a><br><br>
25 </div> 25 </div>
26 <h3>Filters</h3> 26 <h3>Filters</h3>
27 <pre>||testpages.adblockplus.org/en/exceptions/popup^$popup</pre> 27 <pre>||{{ site_url|strip_proto }}/en/exceptions/popup^$popup</pre>
28 <pre>@@||testpages.adblockplus.org/en/exceptions/popup^$popup</pre> 28 <pre>@@||{{ site_url|strip_proto }}/en/exceptions/popup^$popup</pre>
29 </section> 29 </section>
30 30
31 <section class="site-panel"> 31 <section class="site-panel">
32 <h2>Script-based popup</h2> 32 <h2>Script-based popup</h2>
33 <div class="testcase-container"> 33 <div class="testcase-container">
34 <button onclick="do_popup();">window.open() popup</button> 34 <button onclick="do_popup();">window.open() popup</button>
35 </div> 35 </div>
36 <h3>Filters</h3> 36 <h3>Filters</h3>
37 <pre>||testpages.adblockplus.org/en/popuptarget^$popup</pre> 37 <pre>||{{ site_url|strip_proto }}/en/popuptarget^$popup</pre>
38 <pre>@@||testpages.adblockplus.org/en/filters/popup-exception^$popup</pre> 38 <pre>@@||{{ site_url|strip_proto }}/en/filters/popup-exception^$popup</pre>
39 </section> 39 </section>
OLDNEW
« no previous file with comments | « pages/exceptions/image.tmpl ('k') | pages/exceptions/script.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld