pages/exceptions/xmlhttprequest.tmpl - Issue 29874607: Issue 6769 - Avoid hardcoding the URL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: pages/exceptions/xmlhttprequest.tmpl

Issue 29874607: Issue 6769 - Avoid hardcoding the URL (Closed)

Patch Set: Rebased Created Sept. 24, 2018, 1:37 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: pages/exceptions/xmlhttprequest.tmpl

diff --git a/pages/exceptions/xmlhttprequest.tmpl b/pages/exceptions/xmlhttprequest.tmpl

index 113cb3772326b382a20e56ea9e04f4aca4ecf1bb..b15d914907844eeb3158dc47157dfd8e79915f41 100644

--- a/pages/exceptions/xmlhttprequest.tmpl

+++ b/pages/exceptions/xmlhttprequest.tmpl

@@ -18,7 +18,7 @@ function makerequest() {

var req = new XMLHttpRequest();

req.addEventListener("error", failed);

req.addEventListener("abort", aborted);

- req.open("GET", "https://testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/text.txt", true);

+ req.open("GET", "{{ site_url }}/testcasefiles/xmlhttprequestexception/text.txt", true);

req.onload = function(e) {

if (this.status == 200) {

pagelog(this.responseText);

@@ -52,6 +52,6 @@ document.addEventListener('DOMContentLoaded', makerequest, false);

</div>

<h3>Filters</h3>

- <pre>||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*</pre>

- <pre>@@testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/$xmlhttprequest</pre>

+ <pre>||{{ site_url|strip_proto }}/testcasefiles/xmlhttprequestexception/*</pre>

+ <pre>@@{{ site_url|strip_proto }}/testcasefiles/xmlhttprequestexception/$xmlhttprequest</pre>

</section>

« no previous file with comments | « pages/exceptions/subdocument.tmpl ('k') | pages/filters/blocking.tmpl » ('j') | no next file with comments »