cms/bin/xtm_translations/__main__.py - Issue 29886648: Issue #6942 - Add XTM integration in CMS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: cms/bin/xtm_translations/main.py

Issue 29886648: Issue #6942 - Add XTM integration in CMS (Closed)

Patch Set: Addressed initial comments Created Sept. 25, 2018, 12:24 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 from cms.bin.xtm_translations.translate_xtm_cloud import main
	Vasily Kuznetsov 2018/09/26 10:43:15 Most of the code of xtm_translations doesn't need Most of the code of xtm_translations doesn't need to live in cms/bin (which is a directory for scripts). Perhaps a better approach would be to move everything but this file into cms/xtm_translations (maybe even better cms/translations/xtm, just in case we want to have multiple backends at some point) and this file could become cms/bin/xtm_translations.py or have any other name that is appropriate for the CLI frontend. Tudor Avram 2018/10/04 06:48:01 We discussed this in person and, as far as I remem Show quoted text On 2018/09/26 10:43:15, Vasily Kuznetsov wrote: > Most of the code of xtm_translations doesn't need to live in cms/bin (which is a > directory for scripts). Perhaps a better approach would be to move everything > but this file into cms/xtm_translations (maybe even better cms/translations/xtm, > just in case we want to have multiple backends at some point) and this file > could become cms/bin/xtm_translations.py or have any other name that is > appropriate for the CLI frontend. We discussed this in person and, as far as I remember, we decided to do this in a separate ticket? Vasily Kuznetsov 2018/10/05 10:56:24 I think we've decided to do this at the end of thi Show quoted text On 2018/10/04 06:48:01, Tudor Avram wrote: > On 2018/09/26 10:43:15, Vasily Kuznetsov wrote: > > Most of the code of xtm_translations doesn't need to live in cms/bin (which is > a > > directory for scripts). Perhaps a better approach would be to move everything > > but this file into cms/xtm_translations (maybe even better > cms/translations/xtm, > > just in case we want to have multiple backends at some point) and this file > > could become cms/bin/xtm_translations.py or have any other name that is > > appropriate for the CLI frontend. > > We discussed this in person and, as far as I remember, we decided to do this in > a separate ticket? I think we've decided to do this at the end of this review, after everything else is ironed out. Separate ticket would also work, but I prefer to do it in this review to make the history cleaner. Tudor Avram 2018/10/05 12:34:40 Done. Show quoted text On 2018/10/05 10:56:24, Vasily Kuznetsov wrote: > On 2018/10/04 06:48:01, Tudor Avram wrote: > > On 2018/09/26 10:43:15, Vasily Kuznetsov wrote: > > > Most of the code of xtm_translations doesn't need to live in cms/bin (which > is > > a > > > directory for scripts). Perhaps a better approach would be to move > everything > > > but this file into cms/xtm_translations (maybe even better > > cms/translations/xtm, > > > just in case we want to have multiple backends at some point) and this file > > > could become cms/bin/xtm_translations.py or have any other name that is > > > appropriate for the CLI frontend. > > > > We discussed this in person and, as far as I remember, we decided to do this > in > > a separate ticket? > > I think we've decided to do this at the end of this review, after everything > else is ironed out. Separate ticket would also work, but I prefer to do it in > this review to make the history cleaner. Done.
	2

	3

	4 if __name__ == '__main__':

	5 main()

OLD	NEW

« no previous file with comments | « cms/bin/xtm_translations/__init__.py ('k') | cms/bin/xtm_translations/constants.py » ('j') | cms/bin/xtm_translations/constants.py » ('J')

Side by Side Diff: cms/bin/xtm_translations/__main__.py

Side by Side Diff: cms/bin/xtm_translations/main.py