lib/filterListener.js - Issue 29886685: Issue 6856 - Remove FilterStorage.moveSubscription

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/filterListener.js

Issue 29886685: Issue 6856 - Remove FilterStorage.moveSubscription (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Patch Set: Address PS7 comments Created Oct. 2, 2018, 4:09 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/filterListener.js

===================================================================

--- a/lib/filterListener.js

+++ b/lib/filterListener.js

@@ -103,17 +103,16 @@

filterNotifier.on("filter.removed", onFilterRemoved);

filterNotifier.on("filter.disabled", onFilterDisabled);

filterNotifier.on("filter.moved", onGenericChange);

filterNotifier.on("subscription.added", onSubscriptionAdded);

filterNotifier.on("subscription.removed", onSubscriptionRemoved);

filterNotifier.on("subscription.disabled", onSubscriptionDisabled);

filterNotifier.on("subscription.updated", onSubscriptionUpdated);

- filterNotifier.on("subscription.moved", onGenericChange);

filterNotifier.on("subscription.title", onGenericChange);

filterNotifier.on("subscription.fixedTitle", onGenericChange);

filterNotifier.on("subscription.homepage", onGenericChange);

filterNotifier.on("subscription.downloadStatus", onGenericChange);

filterNotifier.on("subscription.lastCheck", onGenericChange);

filterNotifier.on("subscription.errors", onGenericChange);

filterNotifier.on("load", onLoad);

@@ -332,17 +331,17 @@

{

isDirty = 0;

defaultMatcher.clear();

ElemHide.clear();

ElemHideEmulation.clear();

ElemHideExceptions.clear();

Snippets.clear();

- for (let subscription of FilterStorage.subscriptions)

+ for (let subscription of FilterStorage.subscriptions())

{

if (!subscription.disabled)

addFilters(subscription.filters);

}

function onSave()

{

« no previous file with comments | « no previous file | lib/filterStorage.js » ('j') | no next file with comments »