Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browsers/firefox.js

Issue 29891666: Noissue - Enable tests to run on other browser versions (Closed)
Patch Set: Created Sept. 25, 2018, 7:37 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/all.js ('K') | « test/browsers/chromium.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browsers/firefox.js
===================================================================
--- a/test/browsers/firefox.js
+++ b/test/browsers/firefox.js
@@ -17,8 +17,6 @@
"use strict";
-const FIREFOX_VERSION = "57.0";
-
const webdriver = require("selenium-webdriver");
const firefox = require("selenium-webdriver/firefox");
const {Command} = require("selenium-webdriver/lib/command");
@@ -26,20 +24,18 @@
"firefox_download");
exports.platform = "gecko";
-
-exports.ensureBrowser = function()
-{
- return ensureFirefox(FIREFOX_VERSION);
-};
+exports.oldestCompatibleVersion = "57.0";
+exports.ensureBrowser = ensureFirefox;
exports.getDriver = function(browserBinary, devenvPath)
{
- let binary = new firefox.Binary(browserBinary);
- binary.addArguments("-headless");
+ let options = new firefox.Options();
+ options.setBinary(browserBinary);
+ options.headless();
let driver = new webdriver.Builder()
.forBrowser("firefox")
- .setFirefoxOptions(new firefox.Options().setBinary(binary))
+ .setFirefoxOptions(options)
.build();
let cmd = new Command("moz-install-web-ext")
« test/all.js ('K') | « test/browsers/chromium.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld