Issue 6986 - Don't use chromium remote interface on Windows

test/runners/chromium_process.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 15 matching lines @@
 
 // The Chromium version is a build number, quite obscure.
 // Chromium 63.0.3239.x is 508578
 // Chromium 65.0.3325.0 is 530368
 // We currently want Chromiun 63, as we still support it and that's the
 // loweset version that supports WebDriver.
 const CHROMIUM_REVISION = 508578;
 
 function runScript(chromiumPath, script, scriptName, scriptArgs)
 {
+  let {platform} = process;

[Sebastian Noack, 2018/09/28 15:37:00]

Nit: This doesn't seem to be worth a temporary variable, you can just inline
process.platform below.

[hub, 2018/09/28 15:56:35]

Done.

   const options = new chrome.Options()
-        .headless()
         // Disabling sandboxing is needed on some system configurations
         // like Debian 9.
         .addArguments("--no-sandbox")
         .setChromeBinaryPath(chromiumPath);
+  // Headless doesn't seem to work on Windows.
+  if (platform != "win32")
+    options.headless();
 
   const driver = new Builder()
         .forBrowser("chrome")
         .setChromeOptions(options)
         .build();
 
   return executeScript(driver, "Chromium (WebDriver)",
                        script, scriptName, scriptArgs);
 }
 
 module.exports = function(script, scriptName, ...scriptArgs)
 {
   return ensureChromium(CHROMIUM_REVISION)
     .then(chromiumPath => runScript(chromiumPath, script, scriptName, scriptArgs));
 };