Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterComposer.js

Issue 29901596: Issue 6493 - Ensure Firefox draws the "Block element" popup window (Closed)
Patch Set: Created Oct. 4, 2018, 3:29 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterComposer.js
diff --git a/lib/filterComposer.js b/lib/filterComposer.js
index fe5dcdf3071e1762e31cfb4e4bd461a67bbcac23..fbd3289b666f3d701455c64078e995693a1be1df 100644
--- a/lib/filterComposer.js
+++ b/lib/filterComposer.js
@@ -188,6 +188,11 @@ port.on("composer.openDialog", (message, sender) =>
// we must check the response too.
if (!response)
throw new Error();
+
+ // Sometimes Firefox doesn't draw the window's contents initially, so we
+ // resize the window slightly as a workaround.
+ // https://issues.adblockplus.org/ticket/6493
+ browser.windows.update(window.id, {width: 422});
kzar 2018/10/04 15:30:37 For some reason one pixel larger wasn't enough to
Sebastian Noack 2018/10/04 18:38:55 Would it work if we remove the width from the brow
kzar 2018/10/08 14:50:13 Well, I tried that but initially the width of the
}).catch(e =>
{
// Firefox sometimes sets the status for a window to "complete" before
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld