Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/hitLogger.js

Issue 29907589: Issue 7054 - Update the adblockpluscore dependency to 5cb695da5a40, adblockplusui to f86abf2efdfd (Closed)
Patch Set: Address PS12 Comment Created Jan. 8, 2019, 1:02 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/firefoxDataCleanup.js ('k') | lib/indexedDBBackup.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/hitLogger.js
===================================================================
--- a/lib/hitLogger.js
+++ b/lib/hitLogger.js
@@ -16,17 +16,17 @@
*/
/** @module hitLogger */
"use strict";
const {extractHostFromFrame} = require("./url");
const {EventEmitter} = require("../adblockpluscore/lib/events");
-const {FilterStorage} = require("../adblockpluscore/lib/filterStorage");
+const {filterStorage} = require("../adblockpluscore/lib/filterStorage");
const {port} = require("./messaging");
const {RegExpFilter,
ElemHideFilter} = require("../adblockpluscore/lib/filterClasses");
const nonRequestTypes = exports.nonRequestTypes = [
"DOCUMENT", "ELEMHIDE", "SNIPPET", "GENERICBLOCK", "GENERICHIDE", "CSP"
];
@@ -104,22 +104,22 @@
* @param {string[]} selectors The selectors of applied ElemHideFilters
* @param {string[]} filters The text of applied ElemHideEmulationFilters
* @param {string} docDomain The hostname of the document
*/
function logHiddenElements(tabId, selectors, filters, docDomain)
{
if (HitLogger.hasListener(tabId))
{
- for (let subscription of FilterStorage.subscriptions)
+ for (let subscription of filterStorage.subscriptions())
{
if (subscription.disabled)
continue;
- for (let filter of subscription.filters)
+ for (let filter of subscription.filters())
{
// We only know the exact filter in case of element hiding emulation.
// For regular element hiding filters, the content script only knows
// the selector, so we have to find a filter that has an identical
// selector and is active on the domain the match was reported from.
let isActiveElemHideFilter = filter instanceof ElemHideFilter &&
selectors.includes(filter.selector) &&
filter.isActiveOnDomain(docDomain);
« no previous file with comments | « lib/firefoxDataCleanup.js ('k') | lib/indexedDBBackup.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld