dependencies - Issue 29908555: Issue 7035 - Update libadblockplus dependency

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: dependencies

Issue 29908555: Issue 7035 - Update libadblockplus dependency (Closed) Base URL: git@github.com:adblockplus/libadblockplus-android.git@d150f08d5d72de8938c7ebbdccd9b0c4e06b4070

Patch Set: Created Oct. 12, 2018, 9:13 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/
	anton 2018/10/12 09:27:11 isn't better to use gitlab repository instead (sin isn't better to use gitlab repository instead (since it's primary repository)? sergei 2018/10/12 09:42:29 buildtools are still not on gitlab, I would propos Show quoted text On 2018/10/12 09:27:11, anton wrote: > isn't better to use gitlab repository instead (since it's primary repository)? buildtools are still not on gitlab, I would propose for the sake of simplicity just keep github. We could rewrite this file in favor of switching to git in a separate commit. I would propose _root = git:https://gitlab.com/eyeo/adblockplus/ _self = buildtools/ensure_dependencies.py buildtools = git:https://github.com/adblockplus/buildtools@96b22c9 libadblockplus = libadblockplus git:f2df538b1d66b982fba18a0bc36cf27c1b3bc716
2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:2f744887c675 git:96b22c9	3 buildtools = buildtools hg:2f744887c675 git:96b22c9

4 libadblockplus = libadblockplus hg:4f6413dbcf2e git:40f5d4d2d00abe3f94ce69210267 bcce908cd748	4 libadblockplus = libadblockplus git:f2df538b1d66b982fba18a0bc36cf27c1b3bc716

OLD	NEW

« adblock-android/jni/JniFilterEngine.cpp ('K') | « adblock-android/jni/JniFilterEngine.cpp ('k') | no next file » | no next file with comments »