Issue 7452 - Do not cache element hiding filter objects by default

lib/filterListener.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 204 matching lines @@
     snippets.remove(filter);
 }
 
 function onSubscriptionAdded(subscription)
 {
   FilterListener.setDirty(1);
 
   if (!subscription.disabled)
   {
     for (let text of subscription.filterText())
-      addFilter(Filter.fromText(text), [subscription]);
+      addFilter(Filter.fromText(text, false), [subscription]);
   }
 }
 
 function onSubscriptionRemoved(subscription)
 {
   FilterListener.setDirty(1);
 
   if (!subscription.disabled)
   {
     for (let text of subscription.filterText())
-      removeFilter(Filter.fromText(text));
+      removeFilter(Filter.fromText(text, false));
   }
 }
 
 function onSubscriptionDisabled(subscription, newValue)
 {
   FilterListener.setDirty(1);
 
   if (filterStorage.knownSubscriptions.has(subscription.url))
   {
     if (newValue == false)
     {
       for (let text of subscription.filterText())
-        addFilter(Filter.fromText(text), [subscription]);
+        addFilter(Filter.fromText(text, false), [subscription]);
     }
     else
     {
       for (let text of subscription.filterText())
-        removeFilter(Filter.fromText(text));
+        removeFilter(Filter.fromText(text, false));
     }
   }
 }
 
 function onSubscriptionUpdated(subscription, oldFilterText)
 {
   FilterListener.setDirty(1);
 
   if (!subscription.disabled &&
       filterStorage.knownSubscriptions.has(subscription.url))
   {
     for (let text of oldFilterText)
-      removeFilter(Filter.fromText(text));
+      removeFilter(Filter.fromText(text, false));
 
     for (let text of subscription.filterText())
-      addFilter(Filter.fromText(text), [subscription]);
+      addFilter(Filter.fromText(text, false), [subscription]);
   }
 }
 
 function onFilterHitCount(filter, newValue)
 {
   if (newValue == 0)
     FilterListener.setDirty(0);
   else
     FilterListener.setDirty(0.002);
 }
@@ skipping 42 matching lines @@
   ElemHide.clear();
   ElemHideEmulation.clear();
   ElemHideExceptions.clear();
   snippets.clear();
 
   for (let subscription of filterStorage.subscriptions())
   {
     if (!subscription.disabled)
     {
       for (let text of subscription.filterText())
-        addFilter(Filter.fromText(text), [subscription]);
+        addFilter(Filter.fromText(text, false), [subscription]);
     }
   }
 }
 
 function onSave()
 {
   isDirty = 0;
 }