Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browsers/firefox.js

Issue 29938555: Noissue - Upgrade to selenium-webdriver 4.0.0-alpha (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: renamed "loc" to "rect" and change selenium package version request. Created Nov. 8, 2018, 6:59 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « package.json ('k') | test/wrappers/pages.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browsers/firefox.js
===================================================================
--- a/test/browsers/firefox.js
+++ b/test/browsers/firefox.js
@@ -28,29 +28,20 @@
require("geckodriver");
exports.platform = "gecko";
exports.oldestCompatibleVersion = "57.0";
exports.ensureBrowser = ensureFirefox;
exports.getDriver = function(browserBinary, devenvPath)
{
- let options = new firefox.Options();
- options.setBinary(browserBinary);
- options.headless();
-
+ let options = new firefox.Options().setBinary(browserBinary).headless();
let driver = new webdriver.Builder()
.forBrowser("firefox")
.setFirefoxOptions(options)
.build();
- let cmd = new Command("moz-install-web-ext")
+ driver.execute(new Command("install addon")
.setParameter("path", devenvPath)
- .setParameter("temporary", true);
-
- driver.getExecutor().defineCommand(
- cmd.getName(), "POST",
- "/session/:sessionId/moz/addon/install"
- );
- driver.schedule(cmd, `installWebExt(${devenvPath})`);
+ .setParameter("temporary", true));
return driver;
};
« no previous file with comments | « package.json ('k') | test/wrappers/pages.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld