tests/expected_output/static/en/get_page_url - Issue 29979564: Issue 5452 - Improve CMS API for local link generation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: tests/expected_output/static/en/get_page_url

Issue 29979564: Issue 5452 - Improve CMS API for local link generation (Closed) Base URL: https://hg.adblockplus.org/cms/

Patch Set: Address comments on PS1 Created Jan. 14, 2019, 2:56 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 global_canonical_url = https://acme.com/global	1 global_canonical_url = https://acme.com/global

2	2

3 # 'filter' is default page name for the test website, so we check that the	3 # 'filter' is default page name for the test website, so we check that the

4 # link would not include the page name itself.	4 # link would not include the page name itself.

5 filter_canonical_url = https://acme.com/	5 filter_canonical_url = https://acme.com/

	6

	7 page_url = /en/global

	8

	9 page_url_redirect = /en/global
	Vasily Kuznetsov 2019/01/14 16:14:06 It would be useful to also make an expected output It would be useful to also make an expected output for this in German, to really see the difference here. rhowell 2019/01/14 16:59:33 Good idea. Since global was only in English, I swi Show quoted text On 2019/01/14 16:14:06, Vasily Kuznetsov wrote: > It would be useful to also make an expected output for this in German, to really > see the difference here. Good idea. Since global was only in English, I switched to using the translate page instead for one of the examples.
OLD	NEW