lib/matcher.js - Issue 30011555: Issue 7303 - Deprecate the use of String.prototype.substr()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/matcher.js

Issue 30011555: Issue 7303 - Deprecate the use of String.prototype.substr() (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Rebase. Revert changes in hot path. Created Feb. 21, 2019, 6:09 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/matcher.js

===================================================================

--- a/lib/matcher.js

+++ b/lib/matcher.js

@@ -399,17 +399,17 @@

let candidates = pattern.toLowerCase().match(allKeywordsRegExp);

if (!candidates)

return result;

let resultCount = 0xFFFFFF;

let resultLength = 0;

for (let i = 0, l = candidates.length; i < l; i++)

{

- let candidate = candidates[i].substr(1);

+ let candidate = candidates[i].substring(1);

let simpleFilters = this._simpleFiltersByKeyword.get(candidate);

let complexFilters = this._complexFiltersByKeyword.get(candidate);

let count = (typeof simpleFilters != "undefined" ?

simpleFilters.size : 0) +

(typeof complexFilters != "undefined" ?

complexFilters.size : 0);

if (count < resultCount ||

(count == resultCount && candidate.length > resultLength))

« no previous file with comments | « lib/filterClasses.js ('k') | lib/rsa.js » ('j') | no next file with comments »