Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/web.py

Issue 30011569: Issue 7290 - Fix signature production in sitekey_frame.py (Closed) Base URL: https://hg.adblockplus.org/sitescripts
Patch Set: Initial patch Created Feb. 19, 2019, 10:22 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sitescripts/web.py
===================================================================
--- a/sitescripts/web.py
+++ b/sitescripts/web.py
@@ -34,21 +34,19 @@
return decorator
def registerUrlHandler(url, func):
if url in handlers:
raise Exception('A handler for url %s is already registered' % url)
handlers[url] = func
-# https://www.python.org/dev/peps/pep-0333/#url-reconstruction
-
def request_path(environ, include_query=True):
Vasily Kuznetsov 2019/02/19 22:28:53 This function is not used anywhere else and its lo
kzar 2019/02/20 08:12:07 IMO The change for #7290 should just contain this
kzar 2019/02/21 08:12:25 But there's still a bunch of other changes in the
- path = urllib.quote(environ.get('SCRIPT_NAME', '') +
+ path = urllib.quote(environ.get('SCRIPT_NAME', '') or
environ.get('PATH_INFO', ''))
query_string = environ.get('QUERY_STRING', '')
if query_string and include_query:
path += '?' + urllib.quote(query_string)
return path
def basic_auth(config_section='DEFAULT'):

Powered by Google App Engine
This is Rietveld