Issue 7296 - Implement lightweight URL parsing

test/url.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 33 matching lines @@
   callback();
 };
 
 function hostnameToURL(hostname)
 {
   return new URL("http://" + hostname);
 }
 
 function testURLParsing(test, url)
 {
-  // The function expects a normalized URL.
-  url = new URL(url).href;
-
+  // Note: The function expects a normalized URL.
+  // e.g. "http:example.com:80?foo" should already be normalized to
+  // "http://example.com/?foo". If not, the tests will fail.
   let urlInfo = parseURL(url);
 
   // We need to ensure only that our implementation matches that of the URL
   // object.
   let urlObject = new URL(url);
 
   test.equal(urlInfo.href, urlObject.href);
   test.equal(urlInfo.protocol, urlObject.protocol);
   test.equal(urlInfo.hostname, urlObject.hostname);
 
@@ skipping 13 matching lines @@
       // will fail if we don't normalize the document host as well.
       hostnameToURL(documentHostname).hostname
     ),
     expected,
     message
   );
 }
 
 exports.testParseURL = function(test)
 {
-  testURLParsing(test, "https://example.com");
   testURLParsing(test, "https://example.com/");
   testURLParsing(test, "https://example.com/foo");
   testURLParsing(test, "https://example.com/foo/bar");
   testURLParsing(
     test,
     "https://example.com/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "https://example.com:8080");
   testURLParsing(test, "https://example.com:8080/");
   testURLParsing(test, "https://example.com:8080/foo");
   testURLParsing(test, "https://example.com:8080/foo/bar");
   testURLParsing(
     test,
     "https://example.com:8080/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "http://localhost");
   testURLParsing(test, "http://localhost/");
   testURLParsing(test, "http://localhost/foo");
   testURLParsing(test, "http://localhost/foo/bar");
   testURLParsing(
     test,
     "http://localhost/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "https://user@example.com");
   testURLParsing(test, "https://user@example.com/");
   testURLParsing(test, "https://user@example.com/foo");
   testURLParsing(test, "https://user@example.com/foo/bar");
   testURLParsing(
     test,
     "https://user@example.com/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "https://user@example.com:8080");
   testURLParsing(test, "https://user@example.com:8080/");
   testURLParsing(test, "https://user@example.com:8080/foo");
   testURLParsing(test, "https://user@example.com:8080/foo/bar");
   testURLParsing(
     test,
     "https://user@example.com:8080/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "https://user:pass@example.com");
   testURLParsing(test, "https://user:pass@example.com/");
   testURLParsing(test, "https://user:pass@example.com/foo");
   testURLParsing(test, "https://user:pass@example.com/foo/bar");
   testURLParsing(
     test,
     "https://user:pass@example.com/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "https://user:pass@example.com:8080");
   testURLParsing(test, "https://user:pass@example.com:8080/");
   testURLParsing(test, "https://user:pass@example.com:8080/foo");
   testURLParsing(test, "https://user:pass@example.com:8080/foo/bar");
   testURLParsing(
     test,
     "https://user:pass@example.com:8080/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "https://us%40er:pa%40ss@example.com");
   testURLParsing(test, "https://us%40er:pa%40ss@example.com/");
   testURLParsing(test, "https://us%40er:pa%40ss@example.com/foo");
   testURLParsing(test, "https://us%40er:pa%40ss@example.com/foo/bar");
   testURLParsing(
     test,
     "https://us%40er:pa%40ss@example.com/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "https://us%40er:pa%40ss@example.com:8080");
   testURLParsing(test, "https://us%40er:pa%40ss@example.com:8080/");
   testURLParsing(test, "https://us%40er:pa%40ss@example.com:8080/foo");
   testURLParsing(test, "https://us%40er:pa%40ss@example.com:8080/foo/bar");
   testURLParsing(
     test,
     "https://us%40er:pa%40ss@example.com:8080/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "http://192.168.1.1");
   testURLParsing(test, "http://192.168.1.1/");
   testURLParsing(test, "http://192.168.1.1/foo");
   testURLParsing(test, "http://192.168.1.1/foo/bar");
   testURLParsing(
     test,
     "http://192.168.1.1/foo/bar?https://random/foo/bar"
   );
   testURLParsing(
     test,
     "http://192.168.1.1:8080/foo/bar?https://random/foo/bar"
   );
   testURLParsing(
     test,
     "http://user@192.168.1.1:8080/foo/bar?https://random/foo/bar"
   );
   testURLParsing(
     test,
     "http://user:pass@192.168.1.1:8080/foo/bar?https://random/foo/bar"
   );
 
-  testURLParsing(test, "http://[2001:0db8:0000:0042:0000:8a2e:0370:7334]");
-  testURLParsing(test, "http://[2001:0db8:0000:0042:0000:8a2e:0370:7334]/");
-  testURLParsing(test, "http://[2001:0db8:0000:0042:0000:8a2e:0370:7334]/foo");
-  testURLParsing(
-    test,
-    "http://[2001:0db8:0000:0042:0000:8a2e:0370:7334]/foo/bar"
-  );
-  testURLParsing(
-    test,
-    "http://[2001:0db8:0000:0042:0000:8a2e:0370:7334]/foo/bar?https://random/foo/bar"
-  );
-  testURLParsing(
-    test,
-    "http://[2001:0db8:0000:0042:0000:8a2e:0370:7334]:8080/foo/bar?https://random/foo/bar"
-  );
-  testURLParsing(
-    test,
-    "http://user@[2001:0db8:0000:0042:0000:8a2e:0370:7334]:8080/foo/bar?https://random/foo/bar"
-  );
-  testURLParsing(
-    test,
-    "http://user:pass@[2001:0db8:0000:0042:0000:8a2e:0370:7334]:8080/foo/bar?https://random/foo/bar"
-  );
-
-  testURLParsing(test, "ftp://user:pass@example.com:8021");
+  testURLParsing(test, "http://[2001:db8:0:42:0:8a2e:370:7334]/");
+  testURLParsing(test, "http://[2001:db8:0:42:0:8a2e:370:7334]/foo");
+  testURLParsing(
+    test,
+    "http://[2001:db8:0:42:0:8a2e:370:7334]/foo/bar"
+  );
+  testURLParsing(
+    test,
+    "http://[2001:db8:0:42:0:8a2e:370:7334]/foo/bar?https://random/foo/bar"
+  );
+  testURLParsing(
+    test,
+    "http://[2001:db8:0:42:0:8a2e:370:7334]:8080/foo/bar?https://random/foo/bar"
+  );
+  testURLParsing(
+    test,
+    "http://user@[2001:db8:0:42:0:8a2e:370:7334]:8080/foo/bar?https://random/foo/bar"
+  );
+  testURLParsing(
+    test,
+    "http://user:pass@[2001:db8:0:42:0:8a2e:370:7334]:8080/foo/bar?https://random/foo/bar"
+  );
+
   testURLParsing(test, "ftp://user:pass@example.com:8021/");
   testURLParsing(test, "ftp://user:pass@example.com:8021/foo");
   testURLParsing(test, "ftp://user:pass@example.com:8021/foo/bar");
 
   testURLParsing(test, "about:blank");
   testURLParsing(test, "chrome://extensions");
   testURLParsing(
     test,
     "chrome-extension://bhignfpcigccnlfapldlodmhlidjaion/options.html"
   );
@@ skipping 53 matching lines @@
   );
 
   testURLParsing(test, "javascript:window.alert('hello, world');");
   testURLParsing(test, "javascript:#");
 
   testURLParsing(
     test,
     "blob:https://example.com/7ce70a1e-9681-4148-87a8-43cb9171b994"
   );
 
-  testURLParsing(test, "http://[2001:db8::1]");
-  testURLParsing(test, "http://[2001:db8::1]:8080");
-  testURLParsing(test, "http://[::]:8080");
+  testURLParsing(test, "http://[2001:db8::1]/");
+  testURLParsing(test, "http://[2001:db8::1]:8080/");
+  testURLParsing(test, "http://[::]:8080/");
 
   testURLParsing(test, "not-a-standard-scheme:this is arbitrary content");
   testURLParsing(test, "view-source:http://example.com/path");
 
   testURLParsing(
     test,
     "data:text/html,Question?%3Cdiv%20style=%22color:%20#bad%22%3Eidea%3C/div%3E"
   );
 
   test.done();
@@ skipping 223 matching lines @@
     "us-east-1.amazonaws.com"
   );
   test.equal(getBaseDomain("example.amazonaws.com"), "amazonaws.com");
   test.equal(getBaseDomain("amazonaws.com"), "amazonaws.com");
 
   // Edge case.
   test.equal(getBaseDomain(""), "");
 
   test.done();
 };