Noissue - Add '.revision'-file to devbuilds

packagerChrome.py

Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index 42fff4d8d908559a8bb08a0591a7fbdfa6a1a1dd..1845c2e7b980ce427585da6a3e04ebcaa861a7fe 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -354,6 +354,12 @@ def add_devenv_requirements(files, metadata, params):
         )
 
 
+def add_revision_file(base_dir, files):
+    if os.path.exists(os.path.join(base_dir, '.git')):
+        cmd = ['git', 'rev-parse', 'HEAD']
+        files['.revision'] = subprocess.check_output(cmd, cwd=base_dir).strip()
+
+
 def createBuild(baseDir, type='chrome', outFile=None, buildNum=None, releaseBuild=False, keyFile=None, devenv=False):
     metadata = readMetadata(baseDir, type)
     version = getBuildVersion(baseDir, metadata, releaseBuild, buildNum)
@@ -392,6 +398,10 @@ def createBuild(baseDir, type='chrome', outFile=None, buildNum=None, releaseBuil
         import_locales(params, files)
 
     files['manifest.json'] = createManifest(params, files)
+
+    if not releaseBuild and not devenv:
+        add_revision_file(baseDir, files)

[Sebastian Noack, 2019/10/11 21:18:43]

Splitting this out into a function seems unnecessary. Moreover, it seems more
logical to keep the checks together in order to state more obviously that we do
this for all devbuilds built from Git:

  building_from_git = os.path.exists(os.path.join(baseDir, '.git'))
  if not releaseBuild and not devenv and building_from_git:
      cmd = ['git', 'rev-parse', 'HEAD']
      files['.revision'] = subprocess.check_output(cmd, cwd=baseDir)

Note that I also removed the strip() as plain text files are supposed to end
with a new line:
https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-n...

[tlucas, 2019/10/14 12:14:54]

Done.

+
     if type == 'chrome':
         fix_translations_for_chrome(files)