Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4565805475823616: Issue 1984 - Do not use VBScript in installer build tools (Closed)

Created:
April 13, 2015, 10:39 p.m. by Oleksandr
Modified:
June 1, 2015, 9:22 a.m.
Reviewers:
sergei, Eric
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 1984 - Do not use VBScript in installer build tools

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -41 lines) Patch
A installer/emb.py View 1 chunk +29 lines, -0 lines 0 comments Download
R installer/emb.vbs View 1 chunk +0 lines, -40 lines 0 comments Download
M installer/msibuild.cmd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Oleksandr
April 13, 2015, 10:40 p.m. (2015-04-13 22:40:44 UTC) #1
sergei
LGTM if it works.
April 21, 2015, 12:41 p.m. (2015-04-21 12:41:34 UTC) #2
Eric
May 15, 2015, 7:48 p.m. (2015-05-15 19:48:45 UTC) #3
LGTM, with the same caveat Sergei made, that it works. Assuming the python
binding is sane, it looks fine (although I have no experience with this
binding). I didn't see any differences in calls or arguments.

Powered by Google App Engine
This is Rietveld