Issue 1393 - Block element dialog suggests decoded URLs

include.postload.js

Index: include.postload.js
===================================================================
--- a/include.postload.js
+++ b/include.postload.js
@@ -279,11 +279,6 @@
   else if (elt.src)
     url = elt.src;
 
-  // Only normalize when the element contains a URL (issue 328.)
-  // The URL is not always normalized, so do it here
-  if (url)
-    url = normalizeURL(relativeToAbsoluteUrl(url));
-
   // Construct filters. The popup will retrieve these.
   // Only one ID
   var elementId = elt.id ? elt.id.split(' ').join('') : null;
@@ -349,8 +344,13 @@
       if(params[0])
         url = params[0].getAttribute("value");
     }
+
+    // Only normalize when the element contains a URL (issue 328.)
+    // The URL is not always normalized, so do it here

[Wladimir Palant, 2014/09/22 09:57:03]

For reference: this is referring to
https://code.google.com/p/adthwart/issues/detail?id=328 which doesn't really
provide any info. The point here is really that we need to produce a proper URL
and I'm not sure we even need a comment to explain this.

[Thomas Greiner, 2014/09/22 13:13:49]

Done.

+    if (url)
+      url = normalizeURL(relativeToAbsoluteUrl(url));
   } else if(!url) {
-    url = elt.getAttribute("src") || elt.getAttribute("href");
+    url = elt.src || elt.href;
   }
   return url;
 }