Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4605237906112512: Issue 1607 - Create overlays with corresponding z-index (Closed)

Created:
Nov. 25, 2014, 5:53 p.m. by Sebastian Noack
Modified:
Nov. 26, 2014, 1:14 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1607 - Create overlays with corresponding z-index

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M include.postload.js View 1 chunk +7 lines, -1 line 3 comments Download

Messages

Total messages: 5
Sebastian Noack
Nov. 25, 2014, 5:55 p.m. (2014-11-25 17:55:05 UTC) #1
kzar
http://codereview.adblockplus.org/4605237906112512/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/4605237906112512/diff/5629499534213120/include.postload.js#newcode221 include.postload.js:221: overlay.style.zIndex = getComputedStyle(elt.offsetParent).zIndex; We should probably check that elt.offsetParent ...
Nov. 26, 2014, 9:10 a.m. (2014-11-26 09:10:03 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/4605237906112512/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/4605237906112512/diff/5629499534213120/include.postload.js#newcode221 include.postload.js:221: overlay.style.zIndex = getComputedStyle(elt.offsetParent).zIndex; On 2014/11/26 09:10:04, kzar wrote: > ...
Nov. 26, 2014, 9:32 a.m. (2014-11-26 09:32:46 UTC) #3
kzar
LGTM http://codereview.adblockplus.org/4605237906112512/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/4605237906112512/diff/5629499534213120/include.postload.js#newcode221 include.postload.js:221: overlay.style.zIndex = getComputedStyle(elt.offsetParent).zIndex; On 2014/11/26 09:32:46, Sebastian Noack ...
Nov. 26, 2014, 10:53 a.m. (2014-11-26 10:53:30 UTC) #4
Wladimir Palant
Nov. 26, 2014, 1:14 p.m. (2014-11-26 13:14:26 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld