Proxy configurators

src/org/adblockplus/android/CrashHandler.java

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.android;
 
 import java.io.PrintWriter;
 import java.lang.Thread.UncaughtExceptionHandler;
 
+import org.adblockplus.android.compat.LinkProperties;
+import org.adblockplus.android.compat.ProxyProperties;
+
 import android.annotation.SuppressLint;
 import android.app.NotificationManager;
 import android.content.Context;
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager.NameNotFoundException;
 import android.os.Build;
 import android.util.Log;
 
 /**
  * Writes crash data in file.
@@ skipping 130 matching lines @@
     restoreProxy = false;
     int p = 0;
     try
     {
       p = Integer.valueOf(port);
     }
     catch (final NumberFormatException e)
     {
       // ignore - no valid port, it will be correctly processed later
     }
-    ProxySettings.setConnectionProxy(context, host, p, excl);
+
+    try
+    {
+      final ProxyProperties proxyProperties = new ProxyProperties(this.host, p, this.excl);
+      final LinkProperties linkProperties = LinkProperties.fromContext(this.context);
+      if (linkProperties != null && linkProperties.isValid())
+      {
+        linkProperties.setHttpProxy(proxyProperties);
+      }
+    }
+    catch(final Throwable t)

[Felix Dahlke, 2014/08/19 09:06:00]

Space between "catch" and "(".

[René Jeschke, 2014/08/19 10:41:33]

Done.

+    {
+      // TODO we need to clean up this exception handling stuff ... and the compatibility stuff also

[Felix Dahlke, 2014/08/19 09:06:00]

Also something that should be an issue rather than a TODO comment IMO, those are
just bound to keep lying around.

Better have this comment explain why it is safe to ignore exceptions here.

+    }
   }
 }