Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4734126921875456: Issue 1763 - Extend update_update_manifests by timeouts (Closed)

Created:
Jan. 7, 2015, 9:17 p.m. by mathias
Modified:
March 17, 2015, 4:28 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/1763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M modules/updateserver/manifests/init.pp View 1 chunk +2 lines, -1 line 0 comments Download
M modules/updateserver/templates/update_update_manifests.erb View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
mathias
Jan. 7, 2015, 9:17 p.m. (2015-01-07 21:17:47 UTC) #1
Wladimir Palant
See discussion in the issue, this doesn't seem to be the right solution. We have ...
Jan. 8, 2015, 2:16 p.m. (2015-01-08 14:16:05 UTC) #2
mathias
On 2015/01/08 14:16:05, Wladimir Palant wrote: > See discussion in the issue, this doesn't seem ...
Jan. 8, 2015, 3:10 p.m. (2015-01-08 15:10:05 UTC) #3
mathias
Jan. 8, 2015, 3:16 p.m. (2015-01-08 15:16:49 UTC) #4
On 2015/01/08 15:10:05, matze wrote:
> On 2015/01/08 14:16:05, Wladimir Palant wrote:
> > See discussion in the issue, this doesn't seem to be the right solution. We
> have
> > that problem both in the cron job and the fcgi script - the connection to
> > http://services.addons.mozilla.org doesn't close. Adding a timeout on that
> connection
> > in our script should solve this properly.
> 
> Are you sure this is the same issue? What has http://mozilla.org to do with
mercurial
> pulls?

Never mind, now I saw your post in the ticket.

Powered by Google App Engine
This is Rietveld