Issue 1712 - Don't add "Adblock Warning Removal List" subscription on Fennec

lib/ui.js

Index: lib/ui.js
===================================================================
--- a/lib/ui.js
+++ b/lib/ui.js
@@ -817,7 +817,7 @@
     }
 
     // Add "anti-adblock messages" subscription for new users and users updating from old ABP versions
-    if (Services.vc.compare(prevVersion, "2.5") < 0)
+    if ((Services.vc.compare(prevVersion, "2.5") < 0) && !Utils.isFennec)

[Wladimir Palant, 2015/01/06 13:18:12]

I guess there is a misunderstanding here - not adding this list will break the
entire anti-adblock feature. We should keep adding it, but we shouldn't consider
it for the subscription selector. See lib/ui.js, function initCheckboxes(). When
currentSubscription is determined, we filter out the acceptable ads list - we
should filter out the anti-adblock list as well.

[saroyanm, 2015/01/06 16:03:07]

Thanks for pointing this out, but don't we also need to have a checkbox for it
in Fennec ?  Because by default it looks to be disabled, should I create
separate issue for that ?

[Wladimir Palant, 2015/01/06 17:05:21]

It is normally being enabled via the opt-in prompt. I'm not sure whether it was
ever implemented for Firefox Mobile, you can test it by navigating to
bouweenpc.nl for example.

[saroyanm, 2015/01/06 17:32:36]

The prompt is not showing up on mobile unfortunately,  anyway I think this can
be separate issue, I'll investigate that.

     {
       let subscription = Subscription.fromURL(Prefs.subscriptions_antiadblockurl);
       if (subscription && !(subscription.url in FilterStorage.knownSubscriptions))