jni/JniUpdateAvailableCallback.cpp - Issue 4761138508070912: Issue 1848 - Clean up local reference handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: jni/JniUpdateAvailableCallback.cpp

Issue 4761138508070912: Issue 1848 - Clean up local reference handling (Closed)

Patch Set: Formatting, explicit, unrelated change Created Feb. 3, 2015, 1:51 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: jni/JniUpdateAvailableCallback.cpp

diff --git a/jni/JniUpdateAvailableCallback.cpp b/jni/JniUpdateAvailableCallback.cpp

index d8a4b2181e7dc96917137787029bc67bd3eb692e..a7cacffdf6660e578e4d83ac8950882013fbe12b 100644

--- a/jni/JniUpdateAvailableCallback.cpp

+++ b/jni/JniUpdateAvailableCallback.cpp

@@ -41,14 +41,16 @@ void JniUpdateAvailableCallback::Callback(const std::string& arg)

{

JNIEnvAcquire env(GetJavaVM());

- jclass clazz = env->GetObjectClass(GetCallbackObject());

- jmethodID method = env->GetMethodID(clazz, "updateAvailableCallback",

- "(Ljava/lang/String;)V");

+ jmethodID method = env->GetMethodID(

+ *JniLocalReference<jclass>(*env,

+ env->GetObjectClass(GetCallbackObject())),

+ "updateAvailableCallback",

+ "(Ljava/lang/String;)V");

if (method)

{

- jstring jArg = env->NewStringUTF(arg.c_str());

- env->CallVoidMethod(GetCallbackObject(), method, jArg);

+ JniLocalReference<jstring> jArg(*env, env->NewStringUTF(arg.c_str()));

+ env->CallVoidMethod(GetCallbackObject(), method, *jArg);

}

CheckAndLogJavaException(*env);