jni/JniFilter.cpp - Issue 4761138508070912: Issue 1848 - Clean up local reference handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: jni/JniFilter.cpp

Issue 4761138508070912: Issue 1848 - Clean up local reference handling (Closed)

Patch Set: Created Jan. 22, 2015, 6:53 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: jni/JniFilter.cpp

diff --git a/jni/JniFilter.cpp b/jni/JniFilter.cpp

index 9f72448496bc9ab0722a91cbdfe247824715c307..013a31f3f2d1f382edf58ccf95744073f75e09ca 100644

--- a/jni/JniFilter.cpp

+++ b/jni/JniFilter.cpp

@@ -66,9 +66,9 @@ static jobject JNICALL JniGetType(JNIEnv* env, jclass clazz, jlong ptr)

break;

}

- jclass enumClass = env->FindClass(PKG("Filter$Type"));

- jfieldID enumField = env->GetStaticFieldID(enumClass, enumName, TYP("Filter$Type"));

- return env->GetStaticObjectField(enumClass, enumField);

+ JniLocalReference<jclass> enumClass(env, env->FindClass(PKG("Filter$Type")));

+ jfieldID enumField = env->GetStaticFieldID(*enumClass, enumName, TYP("Filter$Type"));

+ return env->GetStaticObjectField(*enumClass, enumField);

}

static jboolean JNICALL JniIsListed(JNIEnv* env, jclass clazz, jlong ptr)

« no previous file with comments | « jni/JniEventCallback.cpp ('k') | jni/JniFilterChangeCallback.cpp » ('j') | no next file with comments »