Issue 1848 - Clean up local reference handling

jni/JniUpdateAvailableCallback.cpp

Index: jni/JniUpdateAvailableCallback.cpp
diff --git a/jni/JniUpdateAvailableCallback.cpp b/jni/JniUpdateAvailableCallback.cpp
index d8a4b2181e7dc96917137787029bc67bd3eb692e..8246eb64d8a33377e0572be1be199726b7e496a2 100644
--- a/jni/JniUpdateAvailableCallback.cpp
+++ b/jni/JniUpdateAvailableCallback.cpp
@@ -41,14 +41,15 @@ void JniUpdateAvailableCallback::Callback(const std::string& arg)
 {
   JNIEnvAcquire env(GetJavaVM());
 
-  jclass clazz = env->GetObjectClass(GetCallbackObject());
-  jmethodID method = env->GetMethodID(clazz, "updateAvailableCallback",
-                                      "(Ljava/lang/String;)V");
+  jmethodID method = env->GetMethodID(
+      *JniLocalReference<jclass>(*env,
+          env->GetObjectClass(GetCallbackObject())), "updateAvailableCallback",

[Felix Dahlke, 2015/02/03 05:22:50]

Just my opinion, but I'd find this easier to read if there was an explicit break
after the continued line:

*JniLocalReference<jclass>(*env,
    env->GetObjectClass(GetCallbackObject())),
"updateAvailableCallback", "(Ljava/lang/String;)V");

[René Jeschke, 2015/02/03 13:51:26]

Done.

+      "(Ljava/lang/String;)V");
 
   if (method)
   {
-    jstring jArg = env->NewStringUTF(arg.c_str());
-    env->CallVoidMethod(GetCallbackObject(), method, jArg);
+    JniLocalReference<jstring> jArg(*env, env->NewStringUTF(arg.c_str()));
+    env->CallVoidMethod(GetCallbackObject(), method, *jArg);
   }
 
   CheckAndLogJavaException(*env);