Unified Diff: jni/JniUpdateCheckDoneCallback.cpp
Issue 4761138508070912:
Issue 1848 - Clean up local reference handling (Closed)
Patch Set: Stupid auto-formatter^^
Created Feb. 4, 2015, 12:04 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« jni/JniUpdateAvailableCallback.cpp ('k')
|
jni/JniWebRequest.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: jni/JniUpdateCheckDoneCallback.cpp |
| diff --git a/jni/JniUpdateCheckDoneCallback.cpp b/jni/JniUpdateCheckDoneCallback.cpp |
| index 817eb462e06a491168348df60b2ee8922d085710..c451fb28feb4350944733c5bc79f14f56a17b770 100644 |
| --- a/jni/JniUpdateCheckDoneCallback.cpp |
| +++ b/jni/JniUpdateCheckDoneCallback.cpp |
| @@ -41,13 +41,16 @@ void JniUpdateCheckDoneCallback::Callback(const std::string& arg) |
| { |
| JNIEnvAcquire env(GetJavaVM()); |
| - jclass clazz = env->GetObjectClass(GetCallbackObject()); |
| - jmethodID method = env->GetMethodID(clazz, "updateCheckDoneCallback", "(Ljava/lang/String;)V"); |
| + jmethodID method = env->GetMethodID( |
| + *JniLocalReference<jclass>(*env, |
| + env->GetObjectClass(GetCallbackObject())), |
| + "updateCheckDoneCallback", |
| + "(Ljava/lang/String;)V"); |
| if (method) |
| { |
| - jstring jArg = env->NewStringUTF(arg.c_str()); |
| - env->CallVoidMethod(GetCallbackObject(), method, jArg); |
| + JniLocalReference<jstring> jArg(*env, env->NewStringUTF(arg.c_str())); |
| + env->CallVoidMethod(GetCallbackObject(), method, *jArg); |
| } |
| CheckAndLogJavaException(*env); |
« no previous file with comments
|
« jni/JniUpdateAvailableCallback.cpp ('k')
|
jni/JniWebRequest.cpp » ('j')
|
no next file with comments »
