Issue #276 - eliminate CString from GetBrowserLanguage

Issue #276 - eliminate CString from GetBrowserLanguage

Change the return type of GetBrowserLanguage from CString to std::wstring. Remove all occurrences of CString from its implementation.

Moved GetBrowserLanguage out of CPluginSystem, since it was not using any static member data. Removed CPluginSystem, because afterwards it was no longer used.

Removed GetSystemLanguage, which was unused.

[Oleksandr, 2014-08-05 11:44:24]

Nice! Shall we move GetBrowserLanguage to Utils in that case then? Looks quite
lonely in it's own file, IMHO. LGTM on this, the move can be done in another
commit, I think.

[sergei, 2014-08-05 12:00:13]

LGTM

[Eric, 2014-08-05 13:20:26]

On 2014/08/05 11:44:24, Oleksandr wrote:
> Nice! Shall we move GetBrowserLanguage to Utils in that case then?

Yes. See below.

> the move can be done in another commit, I think.

The GYP file acts as a hot-spot for commit dependencies, I've noticed, requiring
excess manual work dealing with merges. As a result, I've just decided to leave
out making GYP modifications except where necessary (like new files).

[Eric, 2014-08-05 14:33:34]

FYI.

The other thing I should mention, apropos of this change, is that the settings
class, CPluginSettings, acts a lot like the removed class CPluginSystem. Almost
everything in CPluginSettings doesn't use any private data at all, which means
there are a huge number of extraneous calls to CPluginSettings::GetInstance in
the code.