Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/plugin/PluginTabBase.cpp

Issue 4784041706389504: Issue 1183 - Fix Acceptable Ads hiding (Closed)
Patch Set: Created Aug. 8, 2014, 3:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 #include "PluginStdAfx.h" 1 #include "PluginStdAfx.h"
2 2
3 #include "PluginClient.h" 3 #include "PluginClient.h"
4 #include "PluginSettings.h" 4 #include "PluginSettings.h"
5 #ifdef SUPPORT_CONFIG 5 #ifdef SUPPORT_CONFIG
6 #include "PluginConfig.h" 6 #include "PluginConfig.h"
7 #endif 7 #endif
8 #include "PluginTab.h" 8 #include "PluginTab.h"
9 #include "PluginDomTraverser.h" 9 #include "PluginDomTraverser.h"
10 #include "PluginClass.h" 10 #include "PluginClass.h"
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 { 178 {
179 DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_CREATE_SETTINGS_JAVASCRIPT, PLUGIN_ERROR_CR EATE_SETTINGS_JAVASCRIPT_INVOKE, "CPluginTabBase::InjectABP - Failed to create S ettings in JavaScript"); 179 DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_CREATE_SETTINGS_JAVASCRIPT, PLUGIN_ERROR_CR EATE_SETTINGS_JAVASCRIPT_INVOKE, "CPluginTabBase::InjectABP - Failed to create S ettings in JavaScript");
180 } 180 }
181 } 181 }
182 182
183 void CPluginTabBase::OnDownloadComplete(IWebBrowser2* browser) 183 void CPluginTabBase::OnDownloadComplete(IWebBrowser2* browser)
184 { 184 {
185 #ifdef SUPPORT_DOM_TRAVERSER 185 #ifdef SUPPORT_DOM_TRAVERSER
186 if (!CPluginClient::GetInstance()->IsWhitelistedUrl(std::wstring(GetDocumentUr l()))) 186 if (!CPluginClient::GetInstance()->IsWhitelistedUrl(std::wstring(GetDocumentUr l())))
187 { 187 {
188 m_traverser->TraverseDocument(browser, GetDocumentDomain(), GetDocumentUrl() ); 188 if (CPluginClient::GetInstance()->HidingEnabledOnDomain(std::wstring(GetDocu mentUrl())))
Felix Dahlke 2014/08/08 16:11:35 Oh noes, the arrow pattern! :D Can you merge this
189 {
190 m_traverser->TraverseDocument(browser, GetDocumentDomain(), GetDocumentUrl ());
191 }
189 } 192 }
190 #endif // SUPPORT_DOM_TRAVERSER 193 #endif // SUPPORT_DOM_TRAVERSER
191 194
192 InjectABP(browser); 195 InjectABP(browser);
193 } 196 }
194 197
195 void CPluginTabBase::OnDocumentComplete(IWebBrowser2* browser, const CString& ur l, bool isDocumentBrowser) 198 void CPluginTabBase::OnDocumentComplete(IWebBrowser2* browser, const CString& ur l, bool isDocumentBrowser)
196 { 199 {
197 CString documentUrl = GetDocumentUrl(); 200 CString documentUrl = GetDocumentUrl();
198 201
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 CPluginClient::LogPluginError(pluginError.GetErrorCode(), pluginError. GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), tr ue, pluginError.GetProcessId(), pluginError.GetThreadId()); 389 CPluginClient::LogPluginError(pluginError.GetErrorCode(), pluginError. GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), tr ue, pluginError.GetProcessId(), pluginError.GetThreadId());
387 } 390 }
388 391
389 // Non-hanging sleep 392 // Non-hanging sleep
390 Sleep(50); 393 Sleep(50);
391 } 394 }
392 395
393 tabLoopIteration++; 396 tabLoopIteration++;
394 } 397 }
395 } 398 }
OLDNEW

Powered by Google App Engine
This is Rietveld