Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/plugin/AdblockPlusClient.cpp

Issue 4784041706389504: Issue 1183 - Fix Acceptable Ads hiding (Closed)
Left Patch Set: Addressed comments, reorganized the code Created Aug. 8, 2014, 4:37 p.m.
Right Patch Set: More addressing comments Created Aug. 8, 2014, 4:54 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/plugin/AdblockPlusClient.h ('k') | src/plugin/PluginTabBase.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #include "PluginStdAfx.h" 1 #include "PluginStdAfx.h"
2 #include "PluginSettings.h" 2 #include "PluginSettings.h"
3 #include "PluginSystem.h" 3 #include "PluginSystem.h"
4 #include "PluginFilter.h" 4 #include "PluginFilter.h"
5 #include "PluginClientFactory.h" 5 #include "PluginClientFactory.h"
6 #include "PluginMutex.h" 6 #include "PluginMutex.h"
7 #include "PluginClass.h" 7 #include "PluginClass.h"
8 8
9 #include "AdblockPlusClient.h" 9 #include "AdblockPlusClient.h"
10 10
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 if (!CallEngine(request, response)) 274 if (!CallEngine(request, response))
275 return false; 275 return false;
276 276
277 bool isWhitelisted; 277 bool isWhitelisted;
278 response >> isWhitelisted; 278 response >> isWhitelisted;
279 279
280 DEBUG_GENERAL((L"IsWhitelistedUrl: " + url + L" end").c_str()); 280 DEBUG_GENERAL((L"IsWhitelistedUrl: " + url + L" end").c_str());
281 return isWhitelisted; 281 return isWhitelisted;
282 } 282 }
283 283
284 bool CAdblockPlusClient::IsHidingWhitelistedOnDomain(const std::wstring& domain) 284 bool CAdblockPlusClient::IsElemhideWhitelistedOnDomain(const std::wstring& url)
Felix Dahlke 2014/08/08 16:41:45 s/Hiding/Elemhide? If you rename documentUrl in M
285 { 285 {
286 Communication::OutputBuffer request; 286 Communication::OutputBuffer request;
287 request << Communication::PROC_IS_ELEMHIDE_WHITELISTED_ON_URL << ToUtf8String( domain); 287 request << Communication::PROC_IS_ELEMHIDE_WHITELISTED_ON_URL << ToUtf8String( url);
288 288
289 Communication::InputBuffer response; 289 Communication::InputBuffer response;
290 if (!CallEngine(request, response)) 290 if (!CallEngine(request, response))
291 return false; 291 return false;
292 292
293 bool isWhitelisted; 293 bool isWhitelisted;
294 response >> isWhitelisted; 294 response >> isWhitelisted;
295 return isWhitelisted; 295 return isWhitelisted;
296 } 296 }
297 297
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
578 DEBUG_GENERAL("CompareVersions"); 578 DEBUG_GENERAL("CompareVersions");
579 Communication::OutputBuffer request; 579 Communication::OutputBuffer request;
580 request << Communication::PROC_COMPARE_VERSIONS << ToUtf8String(v1) << ToUtf8S tring(v2); 580 request << Communication::PROC_COMPARE_VERSIONS << ToUtf8String(v1) << ToUtf8S tring(v2);
581 Communication::InputBuffer response; 581 Communication::InputBuffer response;
582 if (!CallEngine(request, response)) 582 if (!CallEngine(request, response))
583 return 0; 583 return 0;
584 int result; 584 int result;
585 response >> result; 585 response >> result;
586 return result; 586 return result;
587 } 587 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld