Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4799232384958464: Issue 2299 - Add adwarefilters to the filtermaster (Closed)

Created:
April 29, 2015, 8:39 a.m. by Felix Dahlke
Modified:
April 30, 2015, 12:29 p.m.
Visibility:
Public.

Description

Issue 2299 - Add adwarefilters to the filtermaster

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add trailing comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M modules/filtermaster/files/sitescripts View 1 chunk +1 line, -0 lines 0 comments Download
M modules/filtermaster/manifests/init.pp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
Felix Dahlke
April 29, 2015, 8:40 a.m. (2015-04-29 08:40:01 UTC) #1
mathias
LGTM.
April 29, 2015, 8:42 a.m. (2015-04-29 08:42:08 UTC) #2
Wladimir Palant
LGTM, up to you whether you want to address the nit. http://codereview.adblockplus.org/4799232384958464/diff/5629499534213120/modules/filtermaster/manifests/init.pp File modules/filtermaster/manifests/init.pp (right): ...
April 29, 2015, 4:09 p.m. (2015-04-29 16:09:01 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/4799232384958464/diff/5629499534213120/modules/filtermaster/manifests/init.pp File modules/filtermaster/manifests/init.pp (right): http://codereview.adblockplus.org/4799232384958464/diff/5629499534213120/modules/filtermaster/manifests/init.pp#newcode113 modules/filtermaster/manifests/init.pp:113: 'adwarefilters' On 2015/04/29 16:09:01, Wladimir Palant wrote: > Nit: ...
April 29, 2015, 4:20 p.m. (2015-04-29 16:20:14 UTC) #4
Wladimir Palant
April 29, 2015, 5:37 p.m. (2015-04-29 17:37:46 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld