Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4802066526502912: Issue 2323 - Make sure to always resolve links in translatable strings (Closed)

Created:
April 15, 2015, 7:11 p.m. by Wladimir Palant
Modified:
April 16, 2015, 7:58 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 2323 - Make sure to always resolve links in translatable strings

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added hreflang attribute #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M cms/converters.py View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
April 15, 2015, 7:11 p.m. (2015-04-15 19:11:13 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4802066526502912/diff/5629499534213120/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/4802066526502912/diff/5629499534213120/cms/converters.py#newcode149 cms/converters.py:149: value = self._params["source"].resolve_link(value, locale)[1] or value Note that this ...
April 15, 2015, 7:13 p.m. (2015-04-15 19:13:05 UTC) #2
Wladimir Palant
I realized that simply replacing href value here isn't sufficient, hreflang attribute needs to be ...
April 15, 2015, 7:24 p.m. (2015-04-15 19:24:33 UTC) #3
Sebastian Noack
April 16, 2015, 7:50 a.m. (2015-04-16 07:50:35 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld