hiera/files/classify.sh - Issue 4810150141493248: Issue 122 - Puppet ENC via Hiera

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: hiera/files/classify.sh

Issue 4810150141493248: Issue 122 - Puppet ENC via Hiera (Closed)

Patch Set: Created Sept. 8, 2014, 11:56 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/bin/sh

	2 HOSTNAME=`echo "$@" \| sed 's/\..*$//'`

	3 ( echo -n 'classes = '; hiera classes ::hostname=$HOSTNAME

	4 echo -n 'parameters = '; hiera parameters ::hostname=$HOSTNAME

	5 echo 'data = {"classes"=>classes, "parameters"=>parameters}'

	6 echo 'print data.to_yaml' ) \

	7 \| ruby -ryaml
	Wladimir Palant 2014/09/09 18:15:06 Wow, that's quite a hack... Why use a shell scrip Wow, that's quite a hack... Why use a shell script to generate a Ruby script dynamically instead of a static Ruby script that will simply get the data from Hiera and convert it to YAML? That should remove the potential security issues here. Note that ideally you wouldn't run Hiera as a separate process (according to https://projects.puppetlabs.com/issues/15183 the output isn't meant for anything other than humans) but rather use the example under https://github.com/puppetlabs/hiera/blob/master/README.md#querying-from-code. mathias 2014/10/08 03:02:33 Of course it's to be converted - this one here was Show quoted text On 2014/09/09 18:15:06, Wladimir Palant wrote: > Wow, that's quite a hack... > > Why use a shell script to generate a Ruby script dynamically instead of a static > Ruby script that will simply get the data from Hiera and convert it to YAML? > That should remove the potential security issues here. > > Note that ideally you wouldn't run Hiera as a separate process (according to > https://projects.puppetlabs.com/issues/15183 the output isn't meant for anything > other than humans) but rather use the example under > https://github.com/puppetlabs/hiera/blob/master/README.md#querying-from-code. Of course it's to be converted - this one here was intended for the proof-of-concept only. A way more sophisticated version in Ruby will be proposed in the next patch-set.
	8

OLD	NEW

« hiera/environments/production ('K') | « hiera/environments/production ('k') | hiera/files/precise.sh » ('j') | hiera/files/precise.sh » ('J')