Issue 122 - Puppet ENC via Hiera

hiera/files/precise.sh

+#!/bin/sh
+
+if [ ! -e /usr/bin/puppet -o ! -e /usr/bin/hiera ]; then
+  sudo apt-key add /vagrant/hiera/files/puppetlabs-keyring.gpg \
+  && sudo cp /vagrant/hiera/files/puppetlabs.list /etc/apt/sources.list.d/ \
+  && echo '
+# Puppetlabs packages (e.g. hiera) would attempt to install a puppet 3.x
+# or later release (which is not available in precise) if not pinned here
+Package: puppet
+Pin: release v=2.7.*
+Pin-Priority: 666
+
+Package: puppet-common
+Pin: release v=2.7.*
+Pin-Priority: 666
+' | sudo tee /etc/apt/preferences.d/puppetlabs \
+  && sudo apt-get -y update \
+  && sudo apt-get -y install puppet \
+  && sudo apt-get -y install hiera-puppet
+fi

[Wladimir Palant, 2014/09/09 18:15:06]

I think you already know my opinion on using shell scripts for anything beyond
the most trivial things :)

It definitely looks like this would be better off as a Python script running
with root privileges (pretty much every operation here requires root privileges
anyway).

[mathias, 2014/10/08 03:02:33]

Indeed, I know about your preferences, and I know that it's common practice to
avoid shell-scripts for non-trivial tasks.
Still, since this is pretty straightforward, short, does not accept any user
input, and is applicable in development only - how does this not classify as
trivial? 

Anyway, the next patch-set will feature an improved version in Python removing
the need to track additional files such as puppetlabs.list etc. and also begin
applicable in other environments.

+
+if [ ! -e /etc/puppet/hiera.yaml ]; then
+  sudo ln -fs /vagrant/hiera/vagrant.yaml /etc/puppet/hiera.yaml
+fi
+
+if [ ! -L /etc/hiera.yaml ]; then
+  rm -f /etc/hiera.yaml
+  ln -fs puppet/hiera.yaml /etc/hiera.yaml

[Wladimir Palant, 2014/09/09 18:15:06]

Doesn't this need root privileges as well?

[mathias, 2014/10/08 03:02:33]

Yes it does. However, with the conversion of classify.sh to
puppet-node-classifier.rb this link is not required any more (we use
/etc/puppet/hiera there).

+fi
+
+if [ ! -e /usr/local/bin/puppet-node-classifier ]; then
+  ln -fs /vagrant/hiera/files/classify.sh /usr/local/bin/puppet-node-classifier

[Wladimir Palant, 2014/09/09 18:15:06]

So puppet-node-classifier is actually our classify.sh? That's pretty misleading
IMHO, the name should reflect that this isn't some default command but rather
our script. Actually, what's wrong with running it from
/vagrant/hiera/files/classify.sh?

Same here btw, doesn't this need root privileges?

[mathias, 2014/10/08 03:02:33]

Agreed, there's no need to "install" the script in the first place, which - of
course - applies to the new Ruby version as well.

+fi