Issue 122 - Puppet ENC via Hiera

modules/nagios/manifests/server.pp

 class nagios::server(
     $domain,
     $certificate,
     $private_key,
     $is_default=false,
     $htpasswd_source,
     $admins,
-    $authority,
+    $zone,
   ) {
 
   File {
     owner  => 'root',
     group  => 'root',
     mode   => 0644
   }
 
   include nginx, 'spawn-fcgi'
 
@@ skipping 98 matching lines @@
   Nagios_command <| |> {
     target => '/etc/nagios3/conf.d/commands.cfg',
     require => Package['nagios3'],
     notify => [File['/etc/nagios3/conf.d/commands.cfg'], Service['nagios3']]
   }
 
   Nagios_host <| |> {
     target => '/etc/nagios3/conf.d/hosts.cfg',
     notify => [File['/etc/nagios3/conf.d/hosts.cfg'], Service['nagios3']]
   }
   <-

[Wladimir Palant, 2015/03/03 20:00:19]

This change seems bogus: hosts.cfg can be written independently of
hostgroups.cfg. Both require nagios3 package however, the directory won't exist
otherwise.

[mathias, 2015/03/04 12:32:37]

You're right regarding Nagios, but it's actually Puppet that caused us to do so:
When using the nagios_host {..: groups => } parameter, it requires the group to
be defined already.

   Nagios_hostgroup <| |> {
     target => '/etc/nagios3/conf.d/hostgroups.cfg',
     require => Package['nagios3'],
     notify => [File['/etc/nagios3/conf.d/hostgroups.cfg'], Service['nagios3']]
   }
 
   Nagios_service <| |> {
     target => '/etc/nagios3/conf.d/services.cfg',
     require => Package['nagios3'],
     notify => [File['/etc/nagios3/conf.d/services.cfg'], Service['nagios3']]
@@ skipping 26 matching lines @@
 
   $nagios_hostgroups = hiera('nagios_hostgroups', {})
   create_resources(nagios_hostgroup, $nagios_hostgroups)
 
   $nagios_generic = hiera('servers')
   create_resources(nagios::server::generic_host, $nagios_generic)
 
   define generic_host(
     $ip,
     $ssh_public_key = undef,
-    $role           = undef,
-    $dns            = undef,
-    $groups         = [],
+    $role = undef,
+    $dns = undef,
+    $groups = [],
   ) {
 
-    $fqdn_name = join([$name, $nagios::server::authority], ".")
+    $fqdn_name = join([$name, $nagios::server::zone], '.')
 
     nagios_host {$fqdn_name:
-      use        => 'generic-host',
+      use => 'generic-host',
       hostgroups => $groups,
     }
   }
 }