Issue 122 - Puppet ENC via Hiera

modules/base/manifests/init.pp

 class base ($zone='adblockplus.org') {
   stage {'pre': before => Stage['main']}
   stage {'post': require => Stage['main']}
 
   class {'users':
     stage => 'pre',
   }
 
   class {'apt':
     always_apt_update => true
@@ skipping 22 matching lines @@
 
   service {'cron':
     ensure => running,
     enable => true,
   }
 
   class {'logrotate':
     stage => 'post'
   }
 
-  $servers = hiera("servers")

[Felix Dahlke, 2015/03/09 23:14:51]

Nit from the Puppet style guide:

"All strings must be enclosed in single quotes, unless they contain variables or
single quotes."

https://docs.puppetlabs.com/guides/style_guide.html#quoting

[mathias, 2015/03/16 12:07:11]

Done.

+  $servers = hiera('servers')
   create_resources(base::explicit_host_record, $servers)
 
   define explicit_host_record(
     $ip,
     $ssh_public_key = undef,
     $role           = undef,
     $dns            = undef,
     $groups         = undef,
   ) {
     
     if is_array($ip) {
       $internal_ip = $ip[0]
     } else {
       $internal_ip = $ip
     }
 
-    $fqdn_name = join([$name, $base::zone], ".")

[Felix Dahlke, 2015/03/09 23:14:51]

Nit: Should be single quotes here too.

[mathias, 2015/03/16 12:07:11]

Done.

+    $fqdn_name = join([$name, $base::zone], '.')
     
     host{$name:
       ensure => present,
       ip => $internal_ip,
       name => $fqdn_name,
       host_aliases => $dns ? {
         undef => [],
         default => $dns,
       }  
     }
 
     if $ssh_public_key != undef {
 
       $name_key = $dns ? {
         undef => $fqdn_name,
         default => $dns,
       }
 
       @sshkey {$name:
         name => $name_key,
         key => $ssh_public_key,
         type => ssh-rsa,
         host_aliases => $ip,
       }
     }
 
   }
 }