Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4819695857303552: Issue 2561 - Installing extensions should not be allowed until official support lands (Closed)

Created:
May 22, 2015, 1:41 p.m. by René Jeschke
Modified:
May 22, 2015, 4:07 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 2561 - Installing extensions should not be allowed until official support lands

Patch Set 1 #

Patch Set 2 : Tabs again #

Total comments: 4

Patch Set 3 : "Wording." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M mobile/android/base/AndroidManifest.xml.in View 1 1 chunk +6 lines, -4 lines 0 comments Download
M mobile/android/chrome/content/browser.js View 1 2 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5
René Jeschke
May 22, 2015, 1:44 p.m. (2015-05-22 13:44:41 UTC) #1
Felix Dahlke
It's not nice, but apparently lockPref doesn't work. Just some comment wording nits :P http://codereview.adblockplus.org/4819695857303552/diff/5668600916475904/mobile/android/chrome/content/browser.js ...
May 22, 2015, 3:03 p.m. (2015-05-22 15:03:31 UTC) #2
René Jeschke
http://codereview.adblockplus.org/4819695857303552/diff/5668600916475904/mobile/android/chrome/content/browser.js File mobile/android/chrome/content/browser.js (right): http://codereview.adblockplus.org/4819695857303552/diff/5668600916475904/mobile/android/chrome/content/browser.js#newcode6084 mobile/android/chrome/content/browser.js:6084: // We force xpinstall.enabled to false here because of ...
May 22, 2015, 3:49 p.m. (2015-05-22 15:49:12 UTC) #3
Felix Dahlke
LGTM, sort of :P
May 22, 2015, 3:51 p.m. (2015-05-22 15:51:19 UTC) #4
René Jeschke
May 22, 2015, 4:05 p.m. (2015-05-22 16:05:15 UTC) #5
Yeah, I feel with you :-D

Powered by Google App Engine
This is Rietveld