Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4835082309206016: Issue 2588 - Use Vagrant box RSA key in hosts.yaml (Closed)

Created:
May 27, 2015, 10:06 a.m. by mathias
Modified:
May 27, 2015, 1:23 p.m.
CC:
Fred, Wladimir Palant
Visibility:
Public.

Description

Issue 2588 - Use Vagrant box RSA key in hosts.yaml

Patch Set 1 #

Patch Set 2 : Issue 2588 - Use Vagrant box RSA key in hosts.yaml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M modules/private-stub/hiera/hosts.yaml View 1 1 chunk +17 lines, -8 lines 0 comments Download

Messages

Total messages: 6
mathias
May 27, 2015, 10:06 a.m. (2015-05-27 10:06:30 UTC) #1
Wladimir Palant
Why don't you just remove these keys? Having them here is absolutely pointless - they ...
May 27, 2015, 10:21 a.m. (2015-05-27 10:21:59 UTC) #2
mathias
On 2015/05/27 10:21:59, Wladimir Palant wrote: > Why don't you just remove these keys? Having ...
May 27, 2015, 10:49 a.m. (2015-05-27 10:49:25 UTC) #3
mathias
An improved version with less repetition and including all boxes..
May 27, 2015, 11:02 a.m. (2015-05-27 11:02:51 UTC) #4
Wladimir Palant
LGTM
May 27, 2015, 11:40 a.m. (2015-05-27 11:40:38 UTC) #5
Felix Dahlke
May 27, 2015, 1:17 p.m. (2015-05-27 13:17:19 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld