chrome/content/tests/notification.js - Issue 4848713646211072: Issue 537 - Consider changes made for marking first few downloads

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/tests/notification.js

Issue 4848713646211072: Issue 537 - Consider changes made for marking first few downloads (Closed)

Patch Set: Created Nov. 11, 2014, 6:01 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/content/tests/notification.js

===================================================================

--- a/chrome/content/tests/notification.js

+++ b/chrome/content/tests/notification.js

@@ -264,7 +264,7 @@

testRunner.runScheduledTasks(1);

equal(parameters,

- "addonName=adblockpluschrome&addonVersion=1.4.1&application=chrome&applicationVersion=27.0&platform=chromium&platformVersion=12.0&lastVersion=3",

+ "addonName=adblockpluschrome&addonVersion=1.4.1&application=chrome&applicationVersion=27.0&platform=chromium&platformVersion=12.0&lastVersion=3&downloadCount=0",

"The correct parameters are sent to the server");

});

@@ -341,7 +341,7 @@

let responseText = JSON.stringify({

notifications: [severityNotification]

});

- Notification._onDownloadSuccess(null, responseText, function() {}, function() {});

+ Notification._onDownloadSuccess({}, responseText, function() {}, function() {});

});

test("URL-specific notification", function()

« no previous file with comments | « no previous file | no next file » | no next file with comments »