Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: html/static/js/ieFirstRun.js

Issue 4859491858251776: Fix the approach used in ieFirstRun.js (Closed)
Left Patch Set: Created March 21, 2014, 4:58 p.m.
Right Patch Set: Formatting nit addressed Created July 16, 2014, 11:19 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « html/static/js/ieEventListenerPolyfill.js ('k') | html/templates/firstRun.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 var AdblockPlus = (function() 1 var AdblockPlus = (function()
2 { 2 {
3 var scopes = { 3 var scopes =
4 prefs: { 4 {
5 Prefs: { documentation_link: "" } 5 prefs:
6 {
7 Prefs: {documentation_link: ""}
6 }, 8 },
7 utils: { 9 utils:
8 Utils: { appLocale: "" } 10 {
11 Utils: {appLocale: ""}
9 }, 12 },
10 filterClasses: { 13 filterClasses:
11 Filter: { 14 {
12 fromText: { 15 Filter:
13 matches: function(param) { return true } 16 {
14 } 17 fromText:
18 {
19 matches: function(param) {return true}
15 } 20 }
16 } 21 }
17 }; 22 }
23 };
18 24
19 var result = { 25 var result =
20 require: function(module) { 26 {
27 require: function(module)
28 {
21 return scopes[module]; 29 return scopes[module];
22 } 30 }
23 }; 31 };
24 32
25 window.addEventListener("load", function() 33 window.addEventListener("load", function()
Wladimir Palant 2014/03/31 09:50:29 This won't work in older IE versions. How about yo
Eric 2014/06/25 16:21:06 And by older, that includes IE 8, unfortunately, a
26 { 34 {
27 result.getMessage = function(section, param) { 35 result.getMessage = function(section, param)
28 return Settings.GetMessage(section, param); 36 {
29 } 37 return Settings.GetMessage(section, param);
38 }
30 scopes.prefs.Prefs.documentation_link = Settings.GetDocumentationLink(); 39 scopes.prefs.Prefs.documentation_link = Settings.GetDocumentationLink();
31 scopes.utils.Utils.appLocale = Settings.GetAppLocale(); 40 scopes.utils.Utils.appLocale = Settings.GetAppLocale();
32 }, false); 41 }, false);
33 42
34 return result; 43 return result;
35 })(); 44 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld