Issue 1528 - Implemented backend for general tab of new options page

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 60 matching lines @@
         this._keys.splice(index, 1);
         this._values.splice(index, 1);
       }
     }
   };
 
   global.ext.PageMap = PageMap;
 
   global.ext.showOptions = function(callback)
   {
+    if (top.location.href.indexOf("options.html") == -1)
+      window.open("options.html", "_blank");
+
     if (callback)
       callback();

[Felix Dahlke, 2015/05/28 20:35:41]

Isn't the callback supposed to be invoked after the options page is opened?

[Thomas Greiner, 2015/06/08 16:12:43]

That's not necessarily correct. It will also be called if the options page is
already open. So if you are on the options page this is always true and
shouldn't lead to a new page being opened.

I added a basic check now to clarify that and also changed the URL since we now
actually have an options page we can open. :)

-    else
-      window.open("http://example.com/options.html", "_blank");
   };
 })(this);