Unified Diff: ext/background.js
Issue 4864767881641984:
Issue 1528 - Implemented backend for general tab of new options page (Closed)
Patch Set: Added addSubscription querystring parameter for testing
Created Jan. 30, 2015, 6:06 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« background.js ('K')
|
« background.js ('k')
|
messageResponder.js » ('j')
|
messageResponder.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: ext/background.js |
| =================================================================== |
| --- a/ext/background.js |
| +++ b/ext/background.js |
| @@ -76,8 +76,11 @@ |
| global.ext.PageMap = PageMap; |
| - global.ext.showOptions = function() |
| + global.ext.showOptions = function(callback) |
| { |
| - window.open("http://example.com/options.html", "_blank"); |
| + if (callback) |
| + callback(); |
|
Felix Dahlke
2015/05/28 20:35:41
Isn't the callback supposed to be invoked after th
Thomas Greiner
2015/06/08 16:12:43
That's not necessarily correct. It will also be ca
|
| + else |
| + window.open("http://example.com/options.html", "_blank"); |
| }; |
| })(this); |
« background.js ('K')
|
« background.js ('k')
|
messageResponder.js » ('j')
|
messageResponder.js » ('J')
