Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4868442016448512: Issue 413 - Don't block YouTube annotations on Safari (Closed)

Created:
May 2, 2014, 7:14 a.m. by Sebastian Noack
Modified:
May 2, 2014, 10:48 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 413 - Don't block YouTube annotations on Safari

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keep blocking overlay ads #

Total comments: 2

Patch Set 3 : Removed invideo parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M safari/include.youtube.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Sebastian Noack
May 2, 2014, 7:16 a.m. (2014-05-02 07:16:32 UTC) #1
Sebastian Noack
May 2, 2014, 10:23 a.m. (2014-05-02 10:23:33 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/4868442016448512/diff/5629499534213120/safari/include.youtube.js File safari/include.youtube.js (right): http://codereview.adblockplus.org/4868442016448512/diff/5629499534213120/safari/include.youtube.js#newcode26 safari/include.youtube.js:26: if (/^((ad|afv|adsense)(_.*)?|(ad3|st)_module|prerolls|interstitial|infringe|invideo)=/.test(pairs[i])) The invideo functionality is used for both ...
May 2, 2014, 10:25 a.m. (2014-05-02 10:25:23 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/4868442016448512/diff/5741031244955648/safari/include.youtube.js File safari/include.youtube.js (right): http://codereview.adblockplus.org/4868442016448512/diff/5741031244955648/safari/include.youtube.js#newcode26 safari/include.youtube.js:26: if (/^((ad|afv|adsense)(_.*)?|(ad3|st)_module|prerolls|interstitial|infringe|invideo|iv_cta_url)=/.test(pairs[i])) I don't think removing invideo parameter is ...
May 2, 2014, 10:26 a.m. (2014-05-02 10:26:05 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/4868442016448512/diff/5741031244955648/safari/include.youtube.js File safari/include.youtube.js (right): http://codereview.adblockplus.org/4868442016448512/diff/5741031244955648/safari/include.youtube.js#newcode26 safari/include.youtube.js:26: if (/^((ad|afv|adsense)(_.*)?|(ad3|st)_module|prerolls|interstitial|infringe|invideo|iv_cta_url)=/.test(pairs[i])) On 2014/05/02 10:26:05, Wladimir Palant wrote: > ...
May 2, 2014, 10:34 a.m. (2014-05-02 10:34:56 UTC) #5
Wladimir Palant
May 2, 2014, 10:36 a.m. (2014-05-02 10:36:31 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld