Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4881420963020800: Default to request type SUBDOCUMENT (Closed)

Created:
Aug. 12, 2014, 1:58 p.m. by Oleksandr
Modified:
Aug. 12, 2014, 10:31 p.m.
Visibility:
Public.

Description

Default to request type SUBDOCUMENT

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/plugin/PluginWbPassThrough.cpp View 1 chunk +1 line, -8 lines 1 comment Download

Messages

Total messages: 3
Oleksandr
http://codereview.adblockplus.org/4881420963020800/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp File src/plugin/PluginWbPassThrough.cpp (right): http://codereview.adblockplus.org/4881420963020800/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp#newcode85 src/plugin/PluginWbPassThrough.cpp:85: return CFilter::contentTypeSubdocument; We don't get any mime type for ...
Aug. 12, 2014, 2:03 p.m. (2014-08-12 14:03:01 UTC) #1
Felix Dahlke
LGTM, I don't see any better way to fix this. Digging into what we can ...
Aug. 12, 2014, 2:05 p.m. (2014-08-12 14:05:14 UTC) #2
Wladimir Palant
Aug. 12, 2014, 2:17 p.m. (2014-08-12 14:17:00 UTC) #3
LGTM but please keep looking into better solution - inferring type from file
extension is inherently broken.

Powered by Google App Engine
This is Rietveld