Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4916569079545856: Noissue - Declare clickHideFilters and selectorList properly (Closed)

Created:
Jan. 16, 2015, 8:27 p.m. by kzar
Modified:
Jan. 21, 2015, 10:32 a.m.
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Visibility:
Public.

Description

Noissue - Declare clickHideFilters and selectorList properly

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use array literals for the declarations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M include.postload.js View 1 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4
kzar
Jan. 16, 2015, 8:30 p.m. (2015-01-16 20:30:29 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/4916569079545856/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/4916569079545856/diff/5629499534213120/include.postload.js#newcode475 include.postload.js:475: var clickHideFilters = new Array(); While changing those lines, ...
Jan. 16, 2015, 8:59 p.m. (2015-01-16 20:59:15 UTC) #2
kzar
http://codereview.adblockplus.org/4916569079545856/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/4916569079545856/diff/5629499534213120/include.postload.js#newcode475 include.postload.js:475: var clickHideFilters = new Array(); On 2015/01/16 20:59:15, Sebastian ...
Jan. 16, 2015, 9:04 p.m. (2015-01-16 21:04:26 UTC) #3
Sebastian Noack
Jan. 16, 2015, 9:07 p.m. (2015-01-16 21:07:01 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld