Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include.postload.js

Issue 4916569079545856: Noissue - Declare clickHideFilters and selectorList properly (Closed)
Left Patch Set: Created Jan. 16, 2015, 8:27 p.m.
Right Patch Set: Use array literals for the declarations. Created Jan. 16, 2015, 9:03 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 // popup asks for them. 465 // popup asks for them.
466 function clickHide_mouseClick(e) 466 function clickHide_mouseClick(e)
467 { 467 {
468 if (!currentElement || !clickHide_activated) 468 if (!currentElement || !clickHide_activated)
469 return; 469 return;
470 470
471 var elt = currentElement; 471 var elt = currentElement;
472 if (currentElement.classList.contains("__adblockplus__overlay")) 472 if (currentElement.classList.contains("__adblockplus__overlay"))
473 elt = currentElement.prisoner; 473 elt = currentElement.prisoner;
474 474
475 var clickHideFilters = new Array(); 475 var clickHideFilters = [];
Sebastian Noack 2015/01/16 20:59:15 While changing those lines, mind using array liter
kzar 2015/01/16 21:04:27 Done.
476 var selectorList = new Array(); 476 var selectorList = [];
477 477
478 var addSelector = function(selector) 478 var addSelector = function(selector)
479 { 479 {
480 if (selectorList.indexOf(selector) != -1) 480 if (selectorList.indexOf(selector) != -1)
481 return; 481 return;
482 482
483 clickHideFilters.push(document.domain + "##" + selector); 483 clickHideFilters.push(document.domain + "##" + selector);
484 selectorList.push(selector); 484 selectorList.push(selector);
485 }; 485 };
486 486
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 element.parentNode.removeChild(element); 689 element.parentNode.removeChild(element);
690 } 690 }
691 clickHide_deactivate(); 691 clickHide_deactivate();
692 break; 692 break;
693 } 693 }
694 }); 694 });
695 695
696 if (window == window.top) 696 if (window == window.top)
697 ext.backgroundPage.sendMessage({type: "report-html-page"}); 697 ext.backgroundPage.sendMessage({type: "report-html-page"});
698 } 698 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld