Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: mobile/android/base/resources/xml/preferences.xml

Issue 4920541991403520: Create a minimal settings UI (Closed)
Patch Set: Cleanup of AddOnBridge Created March 22, 2015, 12:13 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- This Source Code Form is subject to the terms of the Mozilla Public 2 <!-- This Source Code Form is subject to the terms of the Mozilla Public
3 - License, v. 2.0. If a copy of the MPL was not distributed with this 3 - License, v. 2.0. If a copy of the MPL was not distributed with this
4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> 4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
5 5
6 <!-- Preferences screen for pre-v11 Android devices that do not support 6 <!-- Preferences screen for pre-v11 Android devices that do not support
7 PreferenceFragment or ActionBar. Preference changes here should be mirrored 7 PreferenceFragment or ActionBar. Preference changes here should be mirrored
8 to xml-v11/preferences.xml. --> 8 to xml-v11/preferences.xml. -->
9 9
10 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" 10 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
(...skipping 27 matching lines...) Expand all
38 <PreferenceScreen android:title="@string/pref_category_privacy_short" > 38 <PreferenceScreen android:title="@string/pref_category_privacy_short" >
39 <intent android:action="android.intent.action.VIEW" 39 <intent android:action="android.intent.action.VIEW"
40 android:targetPackage="@string/android_package_name" 40 android:targetPackage="@string/android_package_name"
41 android:targetClass="org.mozilla.gecko.preferences.GeckoPreferen ces" > 41 android:targetClass="org.mozilla.gecko.preferences.GeckoPreferen ces" >
42 <extra 42 <extra
43 android:name="resource" 43 android:name="resource"
44 android:value="preferences_privacy" /> 44 android:value="preferences_privacy" />
45 </intent> 45 </intent>
46 </PreferenceScreen> 46 </PreferenceScreen>
47 47
48 <!-- Adblock Plus Browser preferences -->
Felix Dahlke 2015/03/22 13:52:34 "Adblocking preferences" again.
René Jeschke 2015/03/22 15:32:59 Done.
49 <PreferenceScreen android:title="@string/pref_category_display" >
50 <intent android:action="android.intent.action.VIEW"
51 android:targetPackage="@string/android_package_name"
52 android:targetClass="org.mozilla.gecko.preferences.GeckoPreferen ces" >
53 <extra
54 android:name="resource"
55 android:value="preferences_abp_adblockplus" />
Felix Dahlke 2015/03/22 13:52:34 I'd suggest "preferences_adblocking" again.
René Jeschke 2015/03/22 15:32:59 Again: Because we have a sub-preference that is ca
56 </intent>
57 </PreferenceScreen>
58
48 <PreferenceScreen android:title="@string/pref_category_language" > 59 <PreferenceScreen android:title="@string/pref_category_language" >
49 <intent android:action="android.intent.action.VIEW" 60 <intent android:action="android.intent.action.VIEW"
50 android:targetPackage="@string/android_package_name" 61 android:targetPackage="@string/android_package_name"
51 android:targetClass="org.mozilla.gecko.preferences.GeckoPreferen ces" > 62 android:targetClass="org.mozilla.gecko.preferences.GeckoPreferen ces" >
52 <extra 63 <extra
53 android:name="resource" 64 android:name="resource"
54 android:value="preferences_locale" /> 65 android:value="preferences_locale" />
55 </intent> 66 </intent>
56 </PreferenceScreen> 67 </PreferenceScreen>
57 68
(...skipping 10 matching lines...) Expand all
68 <intent android:action="android.intent.action.VIEW" 79 <intent android:action="android.intent.action.VIEW"
69 android:targetPackage="@string/android_package_name" 80 android:targetPackage="@string/android_package_name"
70 android:targetClass="org.mozilla.gecko.preferences.GeckoPreferen ces" > 81 android:targetClass="org.mozilla.gecko.preferences.GeckoPreferen ces" >
71 <extra 82 <extra
72 android:name="resource" 83 android:name="resource"
73 android:value="preferences_devtools" /> 84 android:value="preferences_devtools" />
74 </intent> 85 </intent>
75 </PreferenceScreen> 86 </PreferenceScreen>
76 87
77 </PreferenceScreen> 88 </PreferenceScreen>
OLDNEW

Powered by Google App Engine
This is Rietveld