Create a minimal settings UI

adblockplus/Api.jsm

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 var EXPORTED_SYMBOLS = ["AdblockPlusApi"];
 
 const Cc = Components.classes;
 const Ci = Components.interfaces;
 const Cr = Components.results;
 const Cu = Components.utils;
 
 Cu.import("resource://gre/modules/Services.jsm");
+Cu.import("resource://gre/modules/Messaging.jsm");
 
 function require(module)
 {
   let result = {};
   result.wrappedJSObject = result;
   Services.obs.notifyObservers(result, "adblockplus-require", module);
   return result.exports;
 }
 
 let {FilterStorage} = require("filterStorage");
 let {Prefs} = require("prefs");
 let {UI} = require("ui");
 
 var AdblockPlusApi =
 {
+  get filtersLoaded()
+  {
+    return !FilterStorage._loading;
+  },
   get acceptableAdsEnabled()
   {
     return FilterStorage.subscriptions.some(
       (subscription) => subscription.url == Prefs.subscriptions_exceptionsurl);
   },
   set acceptableAdsEnabled(acceptableAdsEnabled)
   {
     if (acceptableAdsEnabled != AdblockPlusApi.acceptableAdsEnabled)
       UI.toggleAcceptableAds();
+  },
+  initCommunication : function() 

[Felix Dahlke, 2015/03/22 21:05:09]

Nit: No space before :. Also below.

[René Jeschke, 2015/03/22 21:18:15]

Done.

+  {
+    RequestService.addListener((function(data)
+    {
+      if (!data)
+        return {"success" : false, "error" : "malformed request"};
+
+      if (data["action"] == "getFiltersLoaded")
+        return {"success" : true, "value" : this.filtersLoaded};
+
+      if (!this.filtersLoaded)
+        return {"success" : false, "error" : "filters not loaded"};
+
+      switch (data["action"])
+      {
+        case "getAcceptableAdsEnabled":
+          return {"success" : true, "value" : this.acceptableAdsEnabled};
+        case "setAcceptableAdsEnabled":
+          if ("enable" in data)
+          {
+            this.acceptableAdsEnabled = !!data["enable"];
+            return {"success" : true};
+          }
+          return {"success" : false, "error" : "malformed request"};
+        default:
+          return {"success" : false, "error" : "unknown action '" + data["action"] + "'"};
+      }
+      return {"success" : false, "error" : "malformed request"};

[Felix Dahlke, 2015/03/22 21:05:09]

We can't really reach this with the default case above. How about getting rid of
the default case and returning the "no such action" message here?

[René Jeschke, 2015/03/22 21:18:15]

But is 'missing action' the same as 'no such action'?

+    }).bind(this), "AdblockPlus:Api");
   }
 };
+